862704 - Fix failing MobileOperaror unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

The errors really come from a bad status bar test teardown.

patch is coming

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

The errors really come from a bad status bar test teardown. So this patch is
adding a teardown operation to the mock for MobileOperator, and is fixing the
teardown of the tests for status bar.

Sadly, we were really testing the mock for MobileOperator because of that.

This is also reverting part of Bug 844738.
---
 apps/system/test/unit/mock_mobile_operator.js |    6 +++++-
 apps/system/test/unit/statusbar_test.js       |   10 +---------
 2 files changed, 6 insertions(+), 10 deletions(-)

see also PR https://github.com/mozilla-b2g/gaia/pull/9226

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 738382 [details] [diff] [review]
patch v1

The reason sounds sane.
(But I am still questioning a unit test shouldn't affect other unit test..sigh.)

Comment 3

[Julien Wajsberg [:julienw]]

master: 77c105c7b5eb9e23fd40382ecda5b434aa1d11a4