862755 - Reader mode icon from the URL bar corner is almost impossible to access

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Paul Feher]

Firefox for Android 21.0b3 (2013-04-16)
Aurora 22.0a2 (2013-04-17)
Nightly 23.0a1 (2013-04-17)
Devices: LG Nexus 4 (Android 4.2.2), Samsung Galaxy R (Android 2.3.4)

Steps to Reproduce:

1. Open a article on google.news.com
2. Tap on the reader mode icon in the URL bar corner to access the reader mode.

Expected:
The page should be displayed in reader mode.

Actual:
When you tap the reader mode icon, most of the times you access the awesome bar. Only after several tries the page is displayed in reader mode. This is very confusing and uncomfortable for the user.

Note:
Please see the video
http://youtu.be/8qi57J8vPPM

Comment 1

[Aaron Train [:aaronmt]]

Please enable 'Show Touches' in the Android developer options and attach a screenshot of where you are tapping. This will help determine where you are tapping in correlation with the associated hit-point area.

Comment 2

[Paul Feher]

Attachment: Contact_area

As you can see in the screen-shot attached the contact are is situated exactly over the reader mode icon.

Comment 3

[Ian Barlow (:ibarlow)]

This is the weirdest bug, I feel like one day it works, and the next day the icon is impossible to hit again. 

This is what the hit area should really look like for the reader icon. It should be really, really easy to touch. http://cl.ly/image/3y3M200g1n28

Comment 4

[Brian Nicholson (:bnicholson)]

Sriram, didn't you fix this already? Any idea what the problem is now?

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Brian Nicholson (:bnicholson) from comment #4)
> Sriram, didn't you fix this already? Any idea what the problem is now?

AFAIK, sriram fixed the problem of mis-tapping on the tabs button because of the change on view stacking order in the toolbar. I guess we still need to grow the hit area for the stop/reader buttons.

Comment 6

[:Margaret Leibovic]

(In reply to Lucas Rocha (:lucasr) from comment #5)
> (In reply to Brian Nicholson (:bnicholson) from comment #4)
> > Sriram, didn't you fix this already? Any idea what the problem is now?
> 
> AFAIK, sriram fixed the problem of mis-tapping on the tabs button because of
> the change on view stacking order in the toolbar. I guess we still need to
> grow the hit area for the stop/reader buttons.

Yes, I still have a really hard time hitting the reader mode icon.

Comment 7

[Lucas Rocha (:lucasr)]

FYI: I'm fixing this as part bug 858687.

Comment 8

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/10bdfbe0195b

Comment 9

[Lucas Rocha (:lucasr)]

This was fixed with: https://hg.mozilla.org/mozilla-central/rev/08dec3bd99a0

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Lucas, can we uplift this to beta? I can't get into reader mode at all on my Nexus 4 on Beta.

Comment 11

[Lucas Rocha (:lucasr)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #10)
> Lucas, can we uplift this to beta? I can't get into reader mode at all on my
> Nexus 4 on Beta.

The patch that fixed this bug was part of a major refactoring in the toolbar's layout/code. I could try to produce a simpler fix but might still be too risky for beta.