Closed Bug 86276 Opened 24 years ago Closed 23 years ago

split to containing block is not working for XML [INLINE] {ib} (XML blocks do not wrap text)

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.8

People

(Reporter: ian, Assigned: waterson)

References

(
URL
)

Details

(Keywords: css1, regression, testcase, Whiteboard: [Hixie-P1][Hixie-1.0])

Attachments

(5 files, 1 obsolete file)

Example form "XML In A Nutshell" (Harold/Means, O'
1.92 KB, text/xml
Details
A CSS for 12-1.xml (Example form XML In A Nutshell)
549 bytes, text/css
Details
minimal test case
150 bytes, text/xml
Details
Hixie's test case, modified to use <span> and <div>
712 bytes, text/xml
Details
add namespace qualification to :cell-content, as well.
488 bytes, patch
waterson
: review+
waterson
: superreview+
Details | Diff | Splinter Review
STEPS TO REPRODUCE Place a block inside an inline. For example, see http://www.hixie.ch/tests/adhoc/css/box/ib/001-simple-1.xml ACTUAL RESULTS Block sits on the line. EXPECTED RESULTS Block breaks the line. OCCURS WITH Unknown XML content. Not XHTML! TESTCASES http://www.hixie.ch/tests/adhoc/css/box/ib/001.xml (XML case, fails) http://www.hixie.ch/tests/adhoc/css/box/ib/002.xml (XHTML case, passes) http://www.hixie.ch/tests/adhoc/css/box/ib/001-simple-1.xml http://www.hixie.ch/tests/adhoc/css/box/ib/001-simple-2.xml
Keywords: css1, mozilla0.9.2, regression, testcase
Whiteboard: [Hixie-P3]
*** Bug 88887 has been marked as a duplicate of this bug. ***
Ok, this one might be the dupe of bug 88887. The full testcase there is http://www.iwaruna.com/learn/xml/com_err.xml I am not 100% sure about that, though. For example, I identified that a paragraph was not wrapped if it contained "margin-left: 20px" property & value. In any case, both the above testcase and the testcases mentioned earlier in this bug broke between builds 06-08-09 (ok) and 06-09-10 (not ok) (commercial builds). This Bonsai query shows checkins to Mozilla tree between 06-08-04 and 06-09-14 (adding some margins to both ends): http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=06%2F08%2F2001+04%3A00%3A00&maxdate=06%2F09%2F2001+14%3A00%3A00&cvsroot=%2Fcvsroot
*** Bug 90560 has been marked as a duplicate of this bug. ***
Summary: split to containing block is not working for XML [INLINE] {ib} → split to containing block is not working for XML [INLINE] {ib} (XML blocks do not wrap text)
Whiteboard: [Hixie-P3] → [Hixie-P1]
I am seeing this bug on Linux as well as Win2K. Is there any way this can get bumped up in priority for 0.9.4? It's a pretty serious regression in the display of XML
Blocks: 97982
Whiteboard: [Hixie-P1] → [Hixie-P1][Hixie-1.0]
Blocks: 103709
The attached files 12-1.xml and recipe.css also show the "missing line-break error" in blocks. They are taken from the book "XML In A Nutshell" of O'Reilly. (In fact i made a little change in recipe.css to make the bullets show). This example worked in Netscape 4.7x, it works in Opera 5.05 and of course it doesn't work at all in Internet Explorer 5.5.
If NS 4.7 does something with the example it is by pure accident - NS 4.7 does not support XML.
Blocks: 113755
*** Bug 113755 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
Attached file minimal test case —
A minimal test case, which happens to work. Hmm.
The above test case works: it's using <span> and <div> directly, instead of <block> and <inline>. Hixie, could you revisit your test case? I think the issue may be with applying the namespace to the <block> and <inline> elements. I don't see any namespace declarations in your <style> block: could that be the problem?
The namespaces in Hixie's test are fine -- and the styles clearly apply, as shown by the colors. Also have a look at the bugs duped against this one.
Okay, never mind. Looks like namespaces are applying just fine.
The anonymous block frame created in nsCSSFrameConstructor::ConstructInline has an incorrect display type of `inline'. Trying to figure out why.
It looks like we're only applying the :-moz-anonymous-block pseudo in the HTML namespace. To fix these test cases, we'll need it to apply in _all_ namespaces. Will this have negative performance ramifications?
Keywords: review
(Do we also need to fix the `:cell-content' pseudo?)
Comment on attachment 65170 [details] [diff] [review] fix: -moz-anonymous-block must apply in all namespaces doh! r=dbaron I'm not sure how the others are used.
Attachment #65170 - Flags: review+
Pulling in since the fix is so trivial.
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: mozilla0.9.9 → mozilla0.9.8
marc, could you sr=? thanks!
Comment on attachment 65170 [details] [diff] [review] fix: -moz-anonymous-block must apply in all namespaces super! sr=attinasi BTW: why not *|*:cell-content too?
Attachment #65170 - Flags: superreview+
r=dbaron on changing :cell-content as well.
Yeah, I'll change both.
Attachment #65170 - Attachment is obsolete: true
Comment on attachment 65287 [details] [diff] [review] add namespace qualification to :cell-content, as well. Assuming r=dbaron and sr=attinasi still apply based on comments above.
Attachment #65287 - Flags: superreview+
Attachment #65287 - Flags: review+
a=blizzard on behalf of drivers for 0.9.7
Keywords: mozilla0.9.7+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 97982 has been marked as a duplicate of this bug. ***
Is this actually fixed? If I download the original testcase (the recipe one) and its corresponding CSS file, it still doesn't wrap correctly. I'm using Build ID: 2002011803 on Linux
I hate to be a pest about this, but the original problem in this bug report of not wrapping XML still exists. At least, it's still broken for me using Linux build 2002020403 from the 0.9.8 branch. See http://bunker.ece.rice.edu/users/brentmh/test.xml Can we reopen this bug, or should I submit a new one?
Done. The new one is Bug 123355
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: