862916 - console.dir() gives blank box if logging filter was off while doing console.dir()

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Girish Sharma [:Optimizer]]

STR (in a latest nightly) :

1) Open Web Console
2) Have Logging filter off (all sorts of logging)
3) In the input area, type console.dir(window);
4) undefined comes as output. That is okay.
5) Turn on the logging filter.
6) You see blank box with heading [object Proxy]
7) Repeat step 3 and 4, everything normal now.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Problem was that the iframe doesn't load if the iframe itself (or any other parent) is display:none. openVariablesView() throws an exception in onContainerReady (window.document is undefined), but promises hide the exception (meh). This patch avoids the use of display:none for such messages until openVariablesView() is done. Added a test that confirms the fix works.

Comment 2

[Mihai Sucan [:msucan]]

The try push: https://tbpl.mozilla.org/?tree=Try&rev=459b23fc32b9

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 744758 [details] [diff] [review]
proposed fix

Review of attachment 744758 [details] [diff] [review]:
-----------------------------------------------------------------

Nice and clean.

::: browser/devtools/webconsole/test/browser_bug_862916_console_dir_and_filter_off.js
@@ +24,5 @@
> +  registerCleanupFunction(() => hud.setFilterState("log", true));
> +
> +  content.wrappedJSObject.fooBarz = "bug862916";
> +  hud.jsterm.execute("console.dir(window)");
> +  hud.jsterm.once("variablesview-fetched", (aEvent, aVar) => {

Unrelated to this patch, but at some point we should look into harmonizing the event names across our tools, particularly for events that originate from the same components.

Comment 4

[Mihai Sucan [:msucan]]

(In reply to Panos Astithas [:past] from comment #3)
> Comment on attachment 744758 [details] [diff] [review]
> proposed fix
> 
> Review of attachment 744758 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice and clean.

Thanks for the review!


> :::
> browser/devtools/webconsole/test/
> browser_bug_862916_console_dir_and_filter_off.js
> @@ +24,5 @@
> > +  registerCleanupFunction(() => hud.setFilterState("log", true));
> > +
> > +  content.wrappedJSObject.fooBarz = "bug862916";
> > +  hud.jsterm.execute("console.dir(window)");
> > +  hud.jsterm.once("variablesview-fetched", (aEvent, aVar) => {
> 
> Unrelated to this patch, but at some point we should look into harmonizing
> the event names across our tools, particularly for events that originate
> from the same components.

Good point.


Patch landed:
https://hg.mozilla.org/integration/fx-team/rev/13c1c11245ab

Comment 5

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/13c1c11245ab

Comment 6

[Alfred Kayser]

The style rules for .hidden-message should not be in /skin/, but in /content/ as it is not styling, but functionality.