862929 - ANRReporter sometimes cannot find end of the Fennec stack trace

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

There's a mistake in logic in the fix for bug 845416, which results in the ANR report not cutting off at the end of the Fennec stack trace

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Find end of ANR trace the correct way (v1)

The new logic better handles when the end of stack marker spans across two chunks of data.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 738798 [details] [diff] [review]
Find end of ANR trace the correct way (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 845416

User impact if declined: Mostly a privacy concern. Without this fix, ANR reports sometimes can include stack traces outside of Fennec (e.g. stacks of the system process)

Testing completed (on m-c, etc.): Locally

Risk to taking this patch (and alternatives if risky): Very small; fix only touches the case when we could include other stacks in ANR reports

String or IDL/UUID changes made by this patch: None

Comment 3

[bhavana bajaj [:bajaj]]

Comment on attachment 738798 [details] [diff] [review]
Find end of ANR trace the correct way (v1)

:nchen,Please add qawanted if we need help with verification on branches once this lands or mark this bug verified if you can help with verification here.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8aab5521a29f

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ab3070be609

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8aab5521a29f