If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

If dictionary member needs cx, so should dictionary itself

RESOLVED FIXED in mozilla23

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
mozilla23
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 738665 [details] [diff] [review]
patch
Attachment #738665 - Flags: review?(bzbarsky)
Comment on attachment 738665 [details] [diff] [review]
patch

Please fix the indentation on the last line of dictionaryNeedsCx, and r=me.
Attachment #738665 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 738712 [details] [diff] [review]
4 spaces
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/da960202617a
Comment on attachment 738712 [details] [diff] [review]
4 spaces

Actually, I think it should look more like this:

+    return (any(typeNeedsCx(m.type, descriptorProvider) for m in dictionary.members) or
+            (dictionary.parent and dictionaryNeedsCx(dictionary.parent, descriptorProvider)))
Except without the random line-break bugzilla added.  ;)
https://hg.mozilla.org/mozilla-central/rev/da960202617a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.