862991 - If dictionary member needs cx, so should dictionary itself

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 738665 [details] [diff] [review]
patch

Please fix the indentation on the last line of dictionaryNeedsCx, and r=me.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: 4 spaces

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da960202617a

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 738712 [details] [diff] [review]
4 spaces

Actually, I think it should look more like this:

+    return (any(typeNeedsCx(m.type, descriptorProvider) for m in dictionary.members) or
+            (dictionary.parent and dictionaryNeedsCx(dictionary.parent, descriptorProvider)))

Comment 5

[Boris Zbarsky [:bzbarsky]]

Except without the random line-break bugzilla added.  ;)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da960202617a