863008 - Showing statistics is broken because of webidl conversion of custom event

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Now that events are webidl objects instead of XPConnect objects, they follow webidl security rules, which means that events created using chrome objects cannot be read from content. This affects the context menu which tries to send a chrome event to the videocontrols binding. The solution is to use a content object to create the event.

Comment 1

[[e-mail]]

Attachment: Possible patch

This patch has an extra line that works around an xbl_scopes issue that was also fixed in toolkit as part of bug 845555, but may or may not get uplifted.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[Philip Chee]

> in toolkit as part of bug 845555, but may or may not get uplifted.
Bug 845555 landed on aurora.

>     var statsShowing = this.onVideo &&
>                        this.target.wrappedJSObject.mozMediaStatisticsShowing;
Don't you need to unwrap this as well?

Comment 4

[[e-mail]]

(In reply to Philip Chee from comment #3)
> > in toolkit as part of bug 845555, but may or may not get uplifted.
> Bug 845555 landed on aurora.
> 
> >     var statsShowing = this.onVideo &&
> >                        this.target.wrappedJSObject.mozMediaStatisticsShowing;
> Don't you need to unwrap this as well?

.wrappedJSObject is the old way to unwrap, I guess I could update it for consistency, but then I'm not sure how to wrap the line (pun intended).

Comment 5

[Philip Chee]

Comment on attachment 738698 [details] [diff] [review]
Proposed patch

r=me

Comment 6

[[e-mail]]

Pushed comm-central changeset 9e3a901b2193.

Comment 7

[[e-mail]]

Comment on attachment 738698 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): Some m-c change as usual
User impact if declined: Menuitem no longer works
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low, only affects the menuitem itself, and dependent m-c fixes have already landed
String changes made by this patch: None

Comment 8

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/8a90de8ec76c
https://hg.mozilla.org/releases/comm-beta/rev/75c893612b00