Closed Bug 863025 Opened 12 years ago Closed 12 years ago

nsUniversalDetector overlooks the UTF-16 BOM if the input contains only the BOM

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23
Tracking Flags:
Tracking Status
firefox21 --- fixed
firefox22 --- fixed
firefox23 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(2 files)

patch
2.14 KB, patch
smontagu
: review+
bajaj
: approval-mozilla-aurora+
bajaj
: approval-mozilla-beta+
Details | Diff | Splinter Review
Reenable the UTF-16BE test for bug 862757
961 bytes, patch
standard8
: review+
Details | Diff | Splinter Review
See bug 862757.
Blocks: 862757
Attached patch patch — — Splinter Review
Also fixed the crazy indent.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #738720 - Flags: review?(smontagu)
Attachment #738720 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/25d7bd2fd8d9
Flags: in-testsuite?
Whiteboard: [leave open]
Target Milestone: --- → mozilla23
Attachment #738998 - Flags: review?(mbanner)
Comment on attachment 738998 [details] [diff] [review] Reenable the UTF-16BE test for bug 862757 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 860180 User impact if declined: Thunderbird will not read some attachments correctly. Testing completed (on m-c, etc.): on c-c. Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #738998 - Flags: approval-mozilla-beta?
Attachment #738998 - Flags: approval-mozilla-aurora?
Comment on attachment 738998 [details] [diff] [review] Reenable the UTF-16BE test for bug 862757 Sorry, wrong patch.
Attachment #738998 - Flags: approval-mozilla-beta?
Attachment #738998 - Flags: approval-mozilla-aurora?
Comment on attachment 738720 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 860180 User impact if declined: Thunderbird will not read some attachments correctly. Testing completed (on m-c, etc.): on c-c. Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #738720 - Flags: approval-mozilla-beta?
Attachment #738720 - Flags: approval-mozilla-aurora?
Attachment #738720 - Flags: approval-mozilla-beta?
Attachment #738720 - Flags: approval-mozilla-beta+
Attachment #738720 - Flags: approval-mozilla-aurora?
Attachment #738720 - Flags: approval-mozilla-aurora+
Comment on attachment 738998 [details] [diff] [review] Reenable the UTF-16BE test for bug 862757 Sorry for the delay, looks good, thanks.
Attachment #738998 - Flags: review?(mbanner) → review+
https://hg.mozilla.org/comm-central/rev/debd86770270
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: