863092 - Make mach run and mach debug run firefox -no-remote

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Joe Drew (not getting mail)]

Ehsan promised he'd do this if I filed the bug. Well, here it is!

Comment 1

[Matt Brubeck (:mbrubeck)]

Note that you can currently do this with "mach run -no-remote" and "mach debug -no-remote".

I think it's a reasonable request to include -no-remote by default, but maybe there should be a way to override it in case you actually *do* want to pass a new command line to the existing process.

How useful would this be as a default option?  Are there many cases where you need -no-remote but don't also need other options like -P or -profile?

Comment 2

[Jeff Hammel]

see also https://bugzilla.mozilla.org/show_bug.cgi?id=858629

Comment 3

[Jeff Hammel]

(fwiw, i have no idea what use case passing -profile serves without -no-remote or if that is just a bug)

Comment 4

[(no longer active)]

There's really very little reason to not use -no-remote for local builds.  The only reason that I can think of is if you're trying to debug our remoting code, and I would definitely not object if somebody writes a patch to add an exception about that when they need it.  ;-)

Comment 5

[(no longer active)]

Attachment: Patch (v1)

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 738868 [details] [diff] [review]
Patch (v1)

Review of attachment 738868 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me! I *always* run with -no-remote. Although I would feel better if we addressed the case where people don't want -no-remote. Follow-up I suppose.

Comment 7

[Jeff Hammel]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> There's really very little reason to not use -no-remote for local builds. 
> The only reason that I can think of is if you're trying to debug our
> remoting code, and I would definitely not object if somebody writes a patch
> to add an exception about that when they need it.  ;-)

Or if you live on the metal and want bleed-of-the-edge firefox for your everyday browser (and no, I don't do that ;)

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/dcc71e2b291c