Closed Bug 863120 Opened 7 years ago Closed 7 years ago

RootAccessibleWrap.mm doesn't #include header files for layout things it uses

Categories

(Core :: Disability Access APIs, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(1 file)

I'm doing some changes to header files in layout and got the
following compile error:

../../../../../accessible/src/mac/RootAccessibleWrap.mm:43:25: error: member access into incomplete type 'nsIFrame'
    nsView *view = frame->GetViewExternal();
                        ^
../../../dist/include/nsPropertyTable.h:44:7: note: forward declaration of 'nsIFrame'
class nsIFrame;
      ^
1 error generated.
make[8]: *** [RootAccessibleWrap.o] Error 1
Attached patch fixSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=d3b9be1a5589
Attachment #738873 - Flags: review?(surkov.alexander)
Comment on attachment 738873 [details] [diff] [review]
fix

Review of attachment 738873 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #738873 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/b806ca8faf50
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.