Closed Bug 863164 Opened 7 years ago Closed 7 years ago
_event _shim .js
355 bytes, text/html
This is causing delays in scrolling and panel opening. Only the <input type=range> shim and phone_lock.js are using mouse events. Seen as part of https://etherpad.mozilla.org/PerformanceWorkshop
Pointer to Github pull-request
Comment on attachment 743650 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9486 redirect to Arthur because I have a lot pending review requests. :(
Attachment #743650 - Flags: review?(ehung) → review?(arthur.chen)
Comment on attachment 743650 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9486 Thank you for the effort. There is a lint error and also something needs to be clarified. Please check my comment in github.
Attachment #743650 - Flags: review?(arthur.chen)
Attachment #743650 - Flags: review+
Thanks for the quick reviews. https://github.com/mozilla-b2g/gaia/commit/d70f64b5d406f4925a8aac6fffbb983a199a3bd1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Nominate for leo+ because the patch improved the performance and also fixed a leo+ bug 856931.
blocking-b2g: --- → leo?
Not blocking but please nominate for v1.1 uplift including a risk assessment to taking this.
Anthony, per comment 7, could you help nominate for v1.1 uplift? Thanks!
Since "Bug 879117 - [Buri][AUD] terrible to adjust ringer & alarm volume in setting" is nominated to leo+, we should uplift the patch to v1-train. I have a test for uplift process with fixing error. It works fine for me.
blocking-b2g: - → leo?
WFM - marking as blocker since duper didn't.
blocking-b2g: leo? → leo+
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x d70f64b5d406f4925a8aac6fffbb983a199a3bd1 <RESOLVE MERGE CONFLICTS> git commit
Because it's a leo+ issue for blocking Bug 879117, I have helped to fix the conflict and merged for v1-train. v1-train: c9c90d0472bafa3df1649b46cfa1e188aad5c446
You need to log in before you can comment on or make changes to this bug.