863164 - Remove mouse_event_shim.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Anthony Ricaud (:rik)]

This is causing delays in scrolling and panel opening. Only the <input type=range> shim and phone_lock.js are using mouse events.

Seen as part of https://etherpad.mozilla.org/PerformanceWorkshop

Comment 1

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9486

Pointer to Github pull-request

Comment 2

[Evelyn Hung]

Comment on attachment 743650 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9486

redirect to Arthur because I have a lot pending review requests. :(

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 743650 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9486

Thank you for the effort. There is a lint error and also something needs to be clarified. Please check my comment in github.

Comment 4

[Anthony Ricaud (:rik)]

Thanks for the quick reviews.

https://github.com/mozilla-b2g/gaia/commit/d70f64b5d406f4925a8aac6fffbb983a199a3bd1

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for leo+ because the patch improved the performance and also fixed a leo+ bug 856931.

Comment 6

[Gabriele Svelto [:gsvelto]]

On v1-train I'm seeing this error when launching the settings app on a device:

E/GeckoConsole(  425): [JavaScript Error: "ReferenceError: MouseEventShim is not defined" {file: "app://settings.gaiamobile.org/js/settings.js" line: 831}]

This should go away if the patch is uplifted.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Not blocking but please nominate for v1.1 uplift including a risk assessment to taking this.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Anthony, per comment 7, could you help nominate for v1.1 uplift? Thanks!

Comment 10

[[e-mail], [e-mail]]

Since "Bug 879117 - [Buri][AUD] terrible to adjust ringer & alarm volume in setting" is nominated to leo+, we should uplift the patch to v1-train. I have a test for uplift process with fixing error. It works fine for me.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

WFM - marking as blocker since duper didn't.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  d70f64b5d406f4925a8aac6fffbb983a199a3bd1
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[[e-mail], [e-mail]]

Because it's a leo+ issue for blocking Bug 879117, I have helped to fix the conflict and merged for v1-train. 

v1-train: c9c90d0472bafa3df1649b46cfa1e188aad5c446