863289 - GC: Continue the rooting of XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed changes

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 739091 [details] [diff] [review]
Proposed changes

Review of attachment 739091 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley

::: js/xpconnect/wrappers/ChromeObjectWrapper.cpp
@@ +183,5 @@
>  
>      // Note that PropIsFromStandardPrototype needs to invoke getPropertyDescriptor
>      // before we've fully entered the policy. Waive our policy.
> +    RootedObject rootedWrapper(cx, wrapper);
> +    RootedId rootedId(cx, id);

Now that we have handles coming in here, we don't need these at all AFAICT.

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Bobby Holley (:bholley) from comment #1)

> Now that we have handles coming in here, we don't need these at all AFAICT.

Indeed, fixed.

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa442c0ebfb2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa442c0ebfb2