Closed Bug 863289 Opened 8 years ago Closed 8 years ago

GC: Continue the rooting of XPConnect

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Attached patch Proposed changesSplinter Review
No description provided.
Attachment #739091 - Flags: review?(bobbyholley+bmo)
Comment on attachment 739091 [details] [diff] [review]
Proposed changes

Review of attachment 739091 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley

::: js/xpconnect/wrappers/ChromeObjectWrapper.cpp
@@ +183,5 @@
>  
>      // Note that PropIsFromStandardPrototype needs to invoke getPropertyDescriptor
>      // before we've fully entered the policy. Waive our policy.
> +    RootedObject rootedWrapper(cx, wrapper);
> +    RootedId rootedId(cx, id);

Now that we have handles coming in here, we don't need these at all AFAICT.
Attachment #739091 - Flags: review?(bobbyholley+bmo) → review+
(In reply to Bobby Holley (:bholley) from comment #1)

> Now that we have handles coming in here, we don't need these at all AFAICT.

Indeed, fixed.
https://hg.mozilla.org/mozilla-central/rev/aa442c0ebfb2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.