863294 - When the phone is in "vibrator mode" we shouldn't play the "sms sent" sound

Status: RESOLVED DUPLICATE of bug 819842

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Etienne Segonzac (:etienne)]

Pretty self explanatory.
Currently an incoming sms won't make a sound, but an outgoing will.

We should probably check the |ring.enabled| settings in the sms app.

Comment 1

[Julien Wajsberg [:julienw]]

I still don't get why the sound is not disabled deeper in gecko. I think the apps should not need to check the pref for such frequent use cases. 

Who could know this ?

Comment 2

[Julien Wajsberg [:julienw]]

Vivien might know who knows.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> I still don't get why the sound is not disabled deeper in gecko. I think the
> apps should not need to check the pref for such frequent use cases. 
> 
> Who could know this ?

Actually the outgoing sms sound is controlled by the app itself. Incoming sound are controlled by the system app itself. I won't be against moving those sounds to the system app itself and so it will be a global place to manage them.

More globally there should normally be no apps settings in the settings apps. So all settings that lives there should affect Gecko or the system app. The others are applications dependent settings and should be controlled directly from the app itself.

The main issue with this is that we don't have a UI for application dependent settings. I would suggest to have a new button next to the close buton when you enter cards mode that brings you to the application settings page. (The transition to display it could be part of the system app).

Applications can maybe declared that via a an entry point in their manifests. What do you think?

Comment 4

[Julien Wajsberg [:julienw]]

So we talked about this IRL and he's now quite convinced (I think ;) ) that Bug 819842 is the road to go ;)

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #3)
> Actually the outgoing sms sound is controlled by the app itself. Incoming
> sound are controlled by the system app itself. I won't be against moving
> those sounds to the system app itself and so it will be a global place to
> manage them.
> 
> More globally there should normally be no apps settings in the settings
> apps. So all settings that lives there should affect Gecko or the system
> app. The others are applications dependent settings and should be controlled
> directly from the app itself.
> 
> The main issue with this is that we don't have a UI for application
> dependent settings. I would suggest to have a new button next to the close
> buton when you enter cards mode that brings you to the application settings
> page. (The transition to display it could be part of the system app).
> 
> Applications can maybe declared that via a an entry point in their
> manifests. What do you think?

The proposal sounds interesting, would you mind filing a new bug about this if you want it?
However, not everything would be displayed in card view. so IMO card view isn't a good place to do this.