863300 - Themes (Modern and Classic) are broken due to Bug 846540

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

Neither Classic nor Modern appear in the Addons Manager Appearance tab. Appears to have been broken by Bug 846540.

Fix is to:
-AC_SUBST(SUITE_VERSION)
+AC_SUBST(SEAMONKEY_VERSION)

Comment 1

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/fdd3e4d77197

Comment 2

[Philip Chee]

Attachment: Patch as checked-in rs=jcranmer rs=bustage fix

Sigh. I forgot to attach the patch. Anyway here it is. Better late than never.

Comment 3

[Tony Mechelynck [:tonymec]]

On upgrade from yesterday's nightly to today's, two new tabs tell me that "another program" wants to install an extension, viz. SeaMonkey default and SeaMonkey Modern themes. If I accept the installation, I'm told that my current 3rd-party theme will be disabled at next restart, in favour of the built-in one. tbpl tells me that the latest L64 nightlies were from comm-central changeset 7ec742c695b8 (shortly before this fix).

I was told over IRC that it was due to this bug.

The following hourly, built after the fix, does not suffer from the same problem:
Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 SeaMonkey/2.20a1 ID:20130419104755 c-c:27503b22e289 m-c:cbfe9618bc2b

Comment 4

[Tony Mechelynck [:tonymec]]

I spoke too fast in comment #3.

The next nightly,
Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 SeaMonkey/2.20a1 ID:20130420003001 c-c:27503b22e289 m-c:dd03d42b01b1

again tells me at fist startup that "some other program" wants to install SeaMonkey default & SeaMonkey Modern. This time I chose "not to allow" the installation (i.e. I left the checkbox unticked and clicked "Continue"). Then I went to the add-ons manager. Both themes were visible and my third-party theme was still enabled.

And yet there was no intervening comm-central changeset (both this nightly and the hourly I was using immediately before were from comm-central changeset 27503b22e289).

I'm going to open a followup bug.

Comment 5

[Tony Mechelynck [:tonymec]]

(In reply to Tony Mechelynck [:tonymec] from comment #4)
[...]
> I'm going to open a followup bug.

bug 864067