863437 - Hide the URL bar if it was shown as a result of navigation

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[(no longer active)]

Currently when you scroll down to hide the URL bar, and click on a link, the URL bar slides down to let you know that things are happening, which is great!  What I would like to see is for it to stay on the screen momentarily when the navigation is done, and then move back up, and let me continue seeing just the content.

Comment 1

[Chris Lord [:cwiiis]]

This is a UX issue, needinfo'ing ibarlow for comment.

Comment 2

[Ian Barlow (:ibarlow)]

As in the title bar would move back up automatically? I'd be open to trying this.

Comment 3

[(no longer active)]

(In reply to comment #2)
> As in the title bar would move back up automatically?

Yes!

Comment 4

[Chris Lord [:cwiiis]]

Only problem with this is that if you navigated to a new page (which is the likely situation), hiding the toolbar will cause the page to scroll - which the original patch did and we decided we didn't like that...

Do we want to do this anyway?

Comment 5

[Ian Barlow (:ibarlow)]

That's the only bit I would be concerned about too. I'd have to try it though to say for sure one way or the other

Comment 6

[(no longer active)]

(In reply to comment #4)
> Only problem with this is that if you navigated to a new page (which is the
> likely situation), hiding the toolbar will cause the page to scroll - which the
> original patch did and we decided we didn't like that...
> 
> Do we want to do this anyway?

I was thinking about loading the page without considering the offset of the toolbar on top of it, and then just slide the toolbar up without touching the page's scroll position.

Comment 7

[Chris Lord [:cwiiis]]

I don't like the idea of obscuring content for every page load that was initiated while the toolbar wasn't on the screen (which will be most of them).

On the other hand, it's really time I moved onto something else now - after bug 858969, this code is actually quite easy to play with. The margin toolbar position is controlled by the margins on the viewport metrics, and all code that touches this is encapsulated in the LayerMarginsAnimator class.

I'm cc'ing some front-end devs that might want to look into this. Personally, I think there are too many caveats here, and given you're likely to be scrolling content, having the toolbar remain visible after a load is no big deal. (so my vote is wontfix, but this is a ux decision and it sounds like ux want apks to play with).

Comment 8

[Chris Lord [:cwiiis]]

Removing blocker on bug 716403 - we can ship without this (not to say this shouldn't be explored though)

Comment 9

[robsmith11]

Any progress on this? I agree that it would be nicer behavior to stay hidden.

Comment 10

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 11

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.