863609 - Broken UI during transition when orientation changes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[leo.bugzilla.gecko]

Precondition: Have more than 30 video files stored in the sdcard.

At Video app, videos list, the UI looks broken during the transition when the device is rotated portrait <-> landscape (see video attached).

Similar problem can be observed when the video is being played, or in the Gallery application (grid and viewer), where the broken UI can be seen during the rotation.

Comment 1

[leo.bugzilla.gecko]

Attachment: Broken UI when device is rotated in video app[1]

Comment 2

[leo.bugzilla.gecko]

Attachment: Broken UI when device is rotated in video app[2]

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Flagging qawanted for more info - does this make it impossible to play any of the videos on the SD card?  If it's just the layout glitch we probably won't block on this.  Also, what's special about having more than 30 videos?  Does this not reproduce with less?

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Still waiting on QA confirm, but for now let's put this to a tracking nomination.  Please feel free to renominate for leo? if this in any way prevents a user from being able to access/play a video on their SD card.

Comment 5

[Gordon Brander :gordonb]

* Is this because of a hard-coded CSS width, or JavaScript hard-coding the width?
* Short term fix: may be acceptable to make app portrait only as long as playing videos may be either portrait or landscape.
* Probably overlap here with the flexible UI efforts. This will have to get fixed properly for flexible UI/Responsive Design to work.

Comment 6

[Tony Chung [:tchung]]

I dont have 30 videos, but i have 10 videos and it all seems to work so far with orientation.   Is there a reason that 30 is a threshold in your testing?  Also, from the two screenshots, i can't tell where the brokeness is; can you point them out?

Comment 7

[Deepa Subramanian]

(In reply to [e-mail] from comment #3)
> Flagging qawanted for more info - does this make it impossible to play any
> of the videos on the SD card?
User is able to play any video from the list even when the files are loading. When the BACK button is pressed on the video,the video list is seen with a progress bar and files continue to load.

> what's special about having more than 30 videos?
When there are more videos 
- The user is able to see a black screen first and then the videos starts to load. User can view the slow performance.
- When orientation is changed, white screen shows up for few seconds and resumes back. (See screenshot attached)

> Does this not reproduce with less?
Does not reproduce when user has 15,25 or 35 videos. 

This issue can be seen when the SD card is almost full(space left on SD card 800KB).

Leo Build ID: 20130507070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/884ad1bbe24e
Gaia: 1bac83700810f27e00a937e34e7c865da02e0215

Comment 8

[Deepa Subramanian]

Attachment: Bug 863609- screenshot

Comment 9

[Leo]

Root cause for this issue:
1. When orientation of phone changes from portrait to landscape and viceversa, "resize" event will be called.In "resize" event there is a call to "textTruncate()" function (to truncate the longer video names).
2. As textTruncate() function consumes more time, Resizing of height and width of list items screen takes more time to adjust according to the phone orientation. This leads to the white patch.

Solution:
1. This issue could be fixed by optimizing the textTruncate() function. In the latest implementation, textTruncate() has been removed and alternative implementation is given by Sam Joch [:samjoch] which consumes very less time to be executed. 
Please refer Bug 859284.