Closed Bug 863715 Opened 7 years ago Closed 7 years ago

Allow uploading full crashreporter symbol package via mozconfig option

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

This patch lets you add MOZ_CRASHREPORTER_UPLOAD_FULL_SYMBOLS=1 to your mozconfig and get full crashreporter symbol packages uploaded to FTP. This will be useful for try.

People already do this by hacking packager.mk, we might as well make it supported.
This didn't actually work on try. Maybe I needed to export that in the mozconfig?
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> This didn't actually work on try. Maybe I needed to export that in the
> mozconfig?

mozconfig is sourced in configure, so that shouldn't matter. Although that probably doesn't explain it all, note that browser/config/mozconfigs/common is not included everywhere (which kind of defeats its purpose).
You were right, that mozconfig wasn't actually included in most mozconfigs. That's confusing. Here I just stuck it in build/mozconfig.common:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/mq/raw-file/1404d4f81bf0/enable-full-symbols

I sanity checked that the patch does what I want locally (using make upload to upload to localhost), but I pushed it to Try just to be really sure (plus it will let me test bug 846864):
https://tbpl.mozilla.org/?tree=Try&rev=d3213be8d48b
Attachment #739602 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/46ebdffcd3c3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.