863715 - Allow uploading full crashreporter symbol package via mozconfig option

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

This patch lets you add MOZ_CRASHREPORTER_UPLOAD_FULL_SYMBOLS=1 to your mozconfig and get full crashreporter symbol packages uploaded to FTP. This will be useful for try.

People already do this by hacking packager.mk, we might as well make it supported.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Allow uploading full crashreporter symbol package via mozconfig option

Comment 2

[(not currently active) Ted Mielczarek]

You'd need this patch applied to make this work on try:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/mq/raw-file/2ac606569b69/enable-full-symbols

Try push with both patches applied:
https://tbpl.mozilla.org/?tree=Try&rev=b57b4f0d1de7

Comment 3

[(not currently active) Ted Mielczarek]

This didn't actually work on try. Maybe I needed to export that in the mozconfig?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> This didn't actually work on try. Maybe I needed to export that in the
> mozconfig?

mozconfig is sourced in configure, so that shouldn't matter. Although that probably doesn't explain it all, note that browser/config/mozconfigs/common is not included everywhere (which kind of defeats its purpose).

Comment 5

[(not currently active) Ted Mielczarek]

You were right, that mozconfig wasn't actually included in most mozconfigs. That's confusing. Here I just stuck it in build/mozconfig.common:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/mq/raw-file/1404d4f81bf0/enable-full-symbols

I sanity checked that the patch does what I want locally (using make upload to upload to localhost), but I pushed it to Try just to be really sure (plus it will let me test bug 846864):
https://tbpl.mozilla.org/?tree=Try&rev=d3213be8d48b

Comment 6

[(not currently active) Ted Mielczarek]

Also I'm an idiot and can't write shell syntax:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/mq/raw-file/b44faf6cd177/enable-full-symbols

https://tbpl.mozilla.org/?tree=Try&rev=701a304d8522

(third time's the charm)

Comment 7

[(not currently active) Ted Mielczarek]

This worked:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-701a304d8522/try-win32/firefox-23.0a1.en-US.win32.crashreporter-symbols-full.zip
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-701a304d8522/try-linux64/firefox-23.0a1.en-US.linux-x86_64.crashreporter-symbols-full.zip

(also, man, the linux debug symbols are *huge*)

Comment 8

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46ebdffcd3c3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/46ebdffcd3c3

Comment 10

[(not currently active) Ted Mielczarek]

I documented how to use this, btw:
https://wiki.mozilla.org/ReleaseEngineering/TryServer#Getting_debug_symbols