Closed Bug 863752 Opened 7 years ago Closed 7 years ago

TypeError in remotexpcshelltests.py / setAppRoot

Categories

(Testing :: General, defect)

x86
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

Traceback (most recent call last):
  File "/home/mozdev/src/testing/xpcshell/remotexpcshelltests.py", line 504, in <module>
    main()
  File "/home/mozdev/src/testing/xpcshell/remotexpcshelltests.py", line 495, in main
    xpcsh = XPCShellRemote(dm, options, args)
  File "/home/mozdev/src/testing/xpcshell/remotexpcshelltests.py", line 67, in __init__
    self.setAppRoot()
  File "/home/mozdev/src/testing/xpcshell/remotexpcshelltests.py", line 80, in setAppRoot
    print "unable to determine app root: " + detail
TypeError: cannot concatenate 'str' and 'DMError' objects
This only happens if you are hacking and do something dumb, like forget to install Fennec. Even so, we should fix it so that you get a decent error message like:

unable to determine app root: Automation Error: Error processing command 'getapproot org.mozilla.fennec_mozdev'; err=' internal error [no context]'
When triggered, produces the output shown in Comment 1.
Attachment #739784 - Flags: review?(jmaher)
Comment on attachment 739784 [details] [diff] [review]
convert exception to string for print

Review of attachment 739784 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.
Attachment #739784 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/25d6b99f826f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.