863776 - Fix SMS tests caused by Bug 843511

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

The errors are caused because I added a Mock for navigator.mozSms in new tests, and it gets picked automatically when running sms_test.js.

I'll move the failing tests done in sms_test.js to thread_ui_test.js where they'll have a better home.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

* rename the desktop mock to not conflict with the unit test mock
* better cleanup in the sms_test 'unit' test
* moved some of the `ThreadUI` tests that were in `sms_test` to `thread_ui_test`
---
 apps/sms/js/message_manager.js              |    2 +-
 apps/sms/js/sms_mock.js                     |    2 +-
 apps/sms/js/thread_ui.js                    |    2 +-
 apps/sms/test/unit/mock_navigatormoz_sms.js |    7 ++-
 apps/sms/test/unit/mock_utils.js            |    5 +-
 apps/sms/test/unit/sms_test.js              |   32 +++---------
 apps/sms/test/unit/thread_ui_test.js        |   75 ++++++++++++++++++++++++++-
 7 files changed, 94 insertions(+), 31 deletions(-)

see also the PR in https://github.com/mozilla-b2g/gaia/pull/9329

I also checked that I could still run the sms app in Firefox with the "debug" profile so it seems fine to me.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: patch v2

Fixed the lint errors that I didn't see yesterday.

https://github.com/mozilla-b2g/gaia/pull/9329 is ready, travis is green.

Comment 3

[Borja Salguero [:borjasalguero]]

Taking a look!

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: patch v3

fixed one last problem that happens when we run the test-agent after another page, as the tests were triggering window.history.back.

updated the PR https://github.com/mozilla-b2g/gaia/pull/9329 as well

Comment 5

[Julien Wajsberg [:julienw]]

master: 0cd9bc4755307186d2b05e11d93c463d532d604f

Comment 6

[Julien Wajsberg [:julienw]]

a=npotb
v1.0.1: c47ef39de04e634d847cc86b6acc616fabce69eb

Comment 7

[Julien Wajsberg [:julienw]]

wait that bug 857943 is uplifted before uplifting this to v1-train.

Comment 8

[Julien Wajsberg [:julienw]]

a=npotb
v1-train: 1b0c3b8ef8eb6e7c5719780a22aa0ea40c51cf5f

I think I was talking about bug 857942 in comment 7.