Closed
Bug 863788
Opened 12 years ago
Closed 12 years ago
move checking for haveDumpedScreen into dumpScreen
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file)
|
3.24 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•12 years ago
|
||
dumpScreen should really be the only place that knows whether we've dumped
the screen or not. Make it so.
Attachment #739672 -
Flags: review?(jmaher)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 739672 [details] [diff] [review]
move checking for haveDumpedScreen into dumpScreen
Review of attachment 739672 [details] [diff] [review]:
-----------------------------------------------------------------
makes sense! Can you double check none of the remote runners implement this differently?
Attachment #739672 -
Flags: review?(jmaher) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #2)
> makes sense! Can you double check none of the remote runners implement this
> differently?
Yup, nobody else touches dumpScreen.
https://hg.mozilla.org/integration/mozilla-inbound/rev/70a6a8693047
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•