Fix some noisy warnings in Android build

RESOLVED FIXED in Firefox 23

Status

()

Core
JavaScript Engine
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla23
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox22 wontfix, firefox23 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 739695 [details] [diff] [review]
fix-Wsign-compare-warnings.patch

Fix -Wsign-compare warning in MacroAssemblerARM::transferMultipleByRunsImpl(). This warning is in a header file so it is very noisy.

js/src/ion/arm/MacroAssembler-arm.h:387:14 [-Wsign-compare] comparison between signed and unsigned integer expressions
Attachment #739695 - Flags: review?(dvander)
(Assignee)

Comment 1

5 years ago
Created attachment 739696 [details] [diff] [review]
fix-Wunused-but-set-variable-warnings.patch

Fix -Wunused-but-set-variable warnings in NunboxAssembler.h. These warnings are in a header file, so they are very noisy.

js/src/methodjit/NunboxAssembler.h:192:21 [-Wunused-but-set-variable] variable 'start' set but not used
js/src/methodjit/NunboxAssembler.h:218:21 [-Wunused-but-set-variable] variable 'start' set but not used
js/src/methodjit/NunboxAssembler.h:243:21 [-Wunused-but-set-variable] variable 'start' set but not used
Assignee: general → cpeterson
Status: NEW → ASSIGNED
Attachment #739696 - Flags: review?(dvander)
Attachment #739695 - Flags: review?(dvander) → review+
Attachment #739696 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/d715a456d2cc
https://hg.mozilla.org/mozilla-central/rev/f7526aecfa5b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.