Closed Bug 863853 Opened 7 years ago Closed 7 years ago

Restrict the new object cache to being used for only GenericObject

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: terrence, Unassigned)

References

Details

Attachments

(1 file)

Attached patch v0Splinter Review
These hunks were in Brian's patch in Bug 851057 and seem reasonable to take. Brian, was this a correctness issue with the JIT changes, a performance tweak, or only a clarity improvement?
Attachment #739771 - Flags: review?(wmccloskey)
Attachment #739771 - Flags: feedback?(bhackett1024)
Attachment #739771 - Flags: review?(terrence)
Attachment #739771 - Flags: review?(terrence) → review+
Comment on attachment 739771 [details] [diff] [review]
v0

Review of attachment 739771 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like a correctness issue, since SingletonObject probably shouldn't be treated any differently than MaybeSingletonObject and TenuredObject. I also noticed that NewArray in jsarray.cpp probably needs to be fixed as well.
Attachment #739771 - Flags: review?(wmccloskey) → review+
Hmm, I thought I added qfolded the same jsarray fix into to this patch. I guess I'll just dup the change into this patch before pushing, since it's trivial.
https://hg.mozilla.org/mozilla-central/rev/38d08b8b3f3e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Attachment #739771 - Flags: feedback?(bhackett1024)
You need to log in before you can comment on or make changes to this bug.