863853 - Restrict the new object cache to being used for only GenericObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

These hunks were in Brian's patch in Bug 851057 and seem reasonable to take. Brian, was this a correctness issue with the JIT changes, a performance tweak, or only a clarity improvement?

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 739771 [details] [diff] [review]
v0

Review of attachment 739771 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like a correctness issue, since SingletonObject probably shouldn't be treated any differently than MaybeSingletonObject and TenuredObject. I also noticed that NewArray in jsarray.cpp probably needs to be fixed as well.

Comment 2

[Terrence Cole [:terrence]]

Hmm, I thought I added qfolded the same jsarray fix into to this patch. I guess I'll just dup the change into this patch before pushing, since it's trivial.

Comment 3

[Terrence Cole [:terrence]]

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=0ccf9f11d4d9

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38d08b8b3f3e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38d08b8b3f3e