863875 - Favicons flickering when clearing recent history

Status: NEW

(Firefox :: Theme, defect)

Description

[u428464]

When I clear recent history, all the favicons flicker. I can only reproduce on UX branch, so it seems related to the Australis tab patches.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Define flicker - are the images disappearing and re-appearing just once? Or disappearing and re-appearing many times? Can you demonstrate with a screencast?

Comment 2

[u428464]

Attachment: Favicons flickering when clearing history

The favicons disappear and re-appear just once after the clear history dialog is dismissed. See video.

Comment 3

[Matthew N. [:MattN]]

I can't reproduce this with UX on Windows 7. Can you make sure you're running an optimized UX Nightly build and see if you can reproduce the problem in safe mode and/or a new profile?

M- until others can reproduce.

Comment 4

[u428464]

Can't reproduce anymore on my other config, but the first screencast was done with a clean profile. The favicons only flicker now after cleaning history when selecting a tab.

Comment 5

[Matthew N. [:MattN]]

(In reply to Guillaume C. [:ge3k0s] from comment #4)
> The favicons only flicker now after cleaning history when selecting a tab.

What do you mean by "when selecting a tab"? Do you mean that clearing the data takes a while and you select a different tab while it's still clearing? Details steps to reproduce would be appreciated.

Comment 6

[u428464]

Steps to reproduce : 
1. Clear history (until it's finished)
2. Select a tab
3. The favicon briefly disappears and reappears.

Comment 7

[Matthew N. [:MattN]]

Thanks for your help! I can now reproduce this on UX Nightly but not on m-c Nightly.

I get the flicker upon hovering a background tab with a favicon after clearing all browsing data. I think we should at least investigate for M6.

Comment 8

[Justin Dolske [:Dolske]]

A couple debug ideas from talking with MattN:

- Possibility selector for "don't show a favicon" (instead of dotted-outline fallback) is somehow getting hit
- Possibly a graphics painting bug (UX only hits it because the layout is different)
- Might help to try paint flashing on UX vs Nightly to see if that's enlightening
- Might talk with gfx  (joedrew!) to see if someone can just help with enlightenment on what might be going on (or even what's _not_ going on).
- Might help to generally look at Clear History side effects to better understand what might be happening

Comment 9

[Mike Conley (:mconley) (:⚙️)]

We don't want this for Australis:M7.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

I can't reproduce this, can you still?

Comment 12

[u428464]

Yes it is still an issue in latest Nightly.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Thanks for the reply, Guillaume.

Given that this is known to have started on the UX branch, I suspect we're not going to get any better of a regression range beyond "when Australis landed on m-c" unless someone is willing to bisect on the UX branch by manually building and testing. Since that seems unlikely and because other front-end engineers have reproduced, I'm going to remove the regressionwindow-wanted keyword.

Comment 14

[:Gijs (he/him)]

Did the UX nightlies go away? You used to be able to use mozregression --branch ux or something...

Comment 15

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #14)
> Did the UX nightlies go away? You used to be able to use mozregression
> --branch ux or something...

--repo ux

would be what I was thinking of. But I haven't seen this. Guillaume, any chance you can find out a regression window?

Comment 16

[u428464]

(In reply to :Gijs Kruitbosch from comment #15)
> (In reply to :Gijs Kruitbosch from comment #14)
> > Did the UX nightlies go away? You used to be able to use mozregression
> > --branch ux or something...
> 
> --repo ux
> 
> would be what I was thinking of. But I haven't seen this. Guillaume, any
> chance you can find out a regression window?

Unfortunately I can't right now, but I'm pretty sure it was regressed by Australis tab work.