Closed
Bug 863957
Opened 12 years ago
Closed 12 years ago
"Assertion failure: JSID_IS_STRING(iden)" with Components.interfacesByID
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jruderman, Assigned: evilpies)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files)
Because of recent changes (bug 790732 and bug 834697), this testcase requires:
user_pref("dom.xbl_scopes", false);
Assertion failure: JSID_IS_STRING(iden), at jsapi.h:1287
|
Reporter | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
The code added in bug 856477 makes this function look like this:
RootedString str(cx, JSID_TO_STRING(id));
if (!mManager || !JSID_IS_STRING(id))
which is no good.
Looks like the second patch in that bug might fix this....
|
||
Updated•12 years ago
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pretty sure I fixed all instances of this problem. The testcase however could be landed.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Surprise, this problem is still there!
|
|
Assignee | |
Updated•12 years ago
|
Attachment #745375 -
Flags: review?(bzbarsky)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 745375 [details] [diff] [review]
v1
r=me
Attachment #745375 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 6•12 years ago
|
||
Time to add checkin-needed? and nominate for uplift to Aurora
|
|
Assignee | |
Comment 7•12 years ago
|
||
Check-in right now. I am not sure if we need to uplift this. I believe this can't be trigger from web code.
Flags: needinfo?(evilpies)
|
|
Assignee | |
Comment 8•12 years ago
|
||
|
|
||
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
||
Comment 11•12 years ago
|
||
Scratch that, read comment 7 - we'll let this ride the trains and ship in FF24.
|
|
||
Updated•12 years ago
|
Flags: needinfo?(evilpies)
|
||
Comment 12•12 years ago
|
||
Why do I get "JavaScript error: https://bug863957.bugzilla.mozilla.org/attachment.cgi?id=739911, line 4: Components.interfacesByID is undefined" using the testcase in a debug build ?
|
|
Reporter | |
Comment 13•12 years ago
|
||
Probably because of bug 790732, which replaced the "real" Components object (which has an 'interfacesByID' method) with a shim.
You need to log in
before you can comment on or make changes to this bug.
Description
•