863975 - Truncated second frame causes assertion failure [@mozilla::image::Decoder::PostDecodeDone]

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

Tested with m-i changeset: 129367:9ff5c0134bbf

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Joe Drew (not getting mail)]

Attachment: PostFrameDone if we're in the middle of a frame and recovering

Our frame counting and error handling has simply changed, so we need to handle the case that we're left in the middle of a frame because a frame is truncated or in error.

https://tbpl.mozilla.org/?tree=Try&rev=2733ba66c1d4

Comment 3

[Joe Drew (not getting mail)]

Attachment: crashtest

This is Christoph's testcase.

Comment 4

[Joe Drew (not getting mail)]

Another try at try since infrastructure gave us false timeouts for much of today: https://tbpl.mozilla.org/?tree=Try&rev=d5db482e2613

Comment 5

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 740375 [details] [diff] [review]
PostFrameDone if we're in the middle of a frame and recovering

Review of attachment 740375 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Joe Drew (not getting mail)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/00ef24d9a3ac
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d35407880ce2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00ef24d9a3ac
https://hg.mozilla.org/mozilla-central/rev/d35407880ce2