863999 - Header in week view displays two months without a separator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Fernando García Gómez, stripTM]

Steps to reproduce:
1. Open the calendar app
2. Switch to the week view
3. Navigate to a week with days in two months (like Sunday April 28 to Wednesday May 1

Expected result:
Header shows "April-May 2013" (or another separator)

Actual result:
Header shows "AprilMay 2013"

Comment 1

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

Confirmed here.

Firefox 1.0.1
Geeksphone Keon

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Confirmed on Inari on Mozilla RIL v1.0.1, also reproduces in pt-BR and Spanish:
Gaia   052253176f3ad495a1086e47a28fffbf07613388
BuildID 20130425070201
Version 18.0

Comment 3

[Deepa Subramanian]

Attachment: Screenshot

Comment 4

[Deepa Subramanian]

Header shows "julioagosto 2013" in Spanish. Please see the Screenshot

This defect still appears on Leo Build ID: 20130710070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5b34e0cda635
Gaia: 61453c4d32beb15a33ec91b2e740e96e5ce45759
Platform Version: 18.1

Comment 5

[bhavana bajaj [:bajaj]]

This is already existing in 1.0.1 and we are too late in 1.1 cycle to resolve this hence nominating for koi?

Comment 6

[Mila Davydova]

Adding localizers to see if they can find a work around for this.

Comment 7

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

Mila, what we need a space between words.

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

This does not depend on localizers, but on code to handle that when showing two months, there should be an space between the two.

Comment 9

[Evan Tseng [:evanxd]]

Hi all,

It's my WIP patch.
https://github.com/evanxd/gaia/commit/041c394ce0f6d78a2c508fb8c5c645229fbb4560

The patch already added a space between the two months.
And I'm working on the integration test for it.

Comment 10

[Dylan Oliver [:doliver]]

Triage: This bug has been added to the v1.2 backlog but is not blocking release

Comment 11

[Evan Tseng [:evanxd]]

Attachment: Pull Request

Hi James,

Please help me review the patch.
Thanks. :)

Comment 12

[James Lal [:lightsofapollo]]

Comment on attachment 795944 [details]
Pull Request

I have on tiny complaint (see github) otherwise this is amazing.... Nice work!

Comment 13

[Evan Tseng [:evanxd]]

Hi James,

I already updated the patch for your comments.
Thanks for the review.

Comment 14

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/f56f364d7af0409729954748122d9e38a6480e82