864039 - PR_INADDR_ANY needs PR_htonl before assignment to inet.ip

Status: RESOLVED FIXED

(NSS :: Tools, defect, P5)

Description

[Wouter van Kesteren]

Attachment: use PR_htonl

https://developer.mozilla.org/en/docs/PRNetAddr states:

The macros PR_AF_INET, PR_AF_INET6, PR_INADDR_ANY, PR_INADDR_LOOPBACK are defined if prio.h is included. PR_INADDR_ANY and PR_INADDR_LOOPBACK are special IPv4 addresses in host byte order, so they must be converted to network byte order before being assigned to the inet.ip field.

Attached is a patch against 1.14.3 to do just that.

Comment 1

[Wouter van Kesteren]

Hey! After 11 years, who would've thought!

Unfortunately i do not see any change in the source code.
https://hg.mozilla.org/projects/nss/file/tip/cmd/httpserv/httpserv.c#l975

Was this mistakenly marked resolved or just not pushed yet or something?

Documentation seems to have been relocated meanwhile but still seems to say the same as it did 11 years ago:

"The macros PR_AF_INET, PR_AF_INET6, PR_INADDR_ANY, PR_INADDR_LOOPBACK are defined if prio.h is included. PR_INADDR_ANY and PR_INADDR_LOOPBACK are special IPv4 addresses in host byte order, so they must be converted to network byte order before being assigned to the inet.ip field." - https://firefox-source-docs.mozilla.org/nspr/reference/prnetaddr.html#description

Comment 2

[Benjamin Beurdouche [:beurdouche]]

@Kai, I closed this inactive but it is not. Actually this seems like an NSPR issue. Can you please retriage this ? : ) Thanks!

Comment 3

[Kai Engert [:KaiE:]]

Actually, it's an issue with the NSS tools.

Comment 4

[Kai Engert [:KaiE:]]

Wouter, thank you. I agree with you. All over the NSPR code I see that PR_INADDR_ANY is used in the way you suggest.

Comment 5

[Kai Engert [:KaiE:]]

Attachment: 864039.patch

This is just merged and has proper author and commit message.

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/3e83234920ae04809155fa502ac77d91ad0903fb