864046 - GC: Almost the last rooting fixes in XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed changes

Sorry for the quantity of review requests.  We are nearing the end now.

Here is a patch for reported hazards in:
 - XPCJSID.cpp
 - XPCJSRuntime.cpp
 - wrappers/FilteringWrapper.cpp
 - wrappers/WaiveXrayWrapper.cpp

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Proposed changes - part 2

Patch for reported hazards in XPConnect header files.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 739998 [details] [diff] [review]
Proposed changes - part 2

Review of attachment 739998 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCQuickStubs.h
@@ +676,5 @@
>      Op *popp = static_cast<Op *>(JS_GetPrivate(ptrobj));
>  
>      v = js::GetFunctionNativeReserved(callee, 1);
>  
> +    JS::RootedValue argval(cx, (argc > 0) ? args[0] : JSVAL_VOID);

args.get(0)

@@ +702,2 @@
>  
>      JS::AutoObjectRooter tvr(cx, funobj);

Rooting a Rooted?

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Proposed changes - part 2 v. 2

Updated patch with Ms2ger's comments.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b9533763879
https://hg.mozilla.org/integration/mozilla-inbound/rev/7712c68becc6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b9533763879
https://hg.mozilla.org/mozilla-central/rev/7712c68becc6