Last Comment Bug 864119 - Don't generate assertions in MathML mochitests
: Don't generate assertions in MathML mochitests
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla23
Assigned To: Catalin Iacob
: Anthony Jones (:kentuckyfriedtakahe, :k17e)
Depends on:
  Show dependency treegraph
Reported: 2013-04-21 03:22 PDT by Catalin Iacob
Modified: 2013-04-30 19:00 PDT (History)
2 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch that removes all assertions (2.56 KB, patch)
2013-04-21 03:34 PDT, Catalin Iacob
karlt: review+
Details | Diff | Splinter Review

Description Catalin Iacob 2013-04-21 03:22:20 PDT
I get a 100% reproducible test failure when running ./mach mochitest-plain layout/mathml/tests on my build:

ERROR TEST-UNEXPECTED-FAIL | /tests/layout/mathml/tests/test_bug553917.html | Assertion count 208 is greater than expected range 204-204 assertions.
Comment 1 Catalin Iacob 2013-04-21 03:31:53 PDT
The assertions are all of the form:

###!!! ASSERTION: FormatStringFromName() without format parameters: use GetStringFromName() instead: 'aParams && aLength', file /home/catalin/hacking/moz/mozilla-central/intl/strres/src/nsStringBundle.cpp, line 186
Comment 2 Catalin Iacob 2013-04-21 03:34:16 PDT
Created attachment 740073 [details] [diff] [review]
Patch that removes all assertions

This patch gets rid of all the assertions by using nsIStringBundle.GetStringFromName instead of nsIStringBundle.formatStringFromName when the format parameters are an empty list.

I don't really know the assertion gets triggered on my machine 208 times instead of 204 on the test machines, but it seems better to get rid of the assertion anyway and use the appropriate method of nsIStringBundle.
Comment 3 Catalin Iacob 2013-04-30 10:43:46 PDT
Adding checkin-needed following karlt's review+
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-04-30 12:14:49 PDT
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-04-30 19:00:01 PDT

Note You need to log in before you can comment on or make changes to this bug.