The default bug view has changed. See this FAQ.

Don't generate assertions in MathML mochitests

RESOLVED FIXED in mozilla23

Status

()

Core
MathML
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Catalin Iacob, Assigned: Catalin Iacob)

Tracking

Trunk
mozilla23
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I get a 100% reproducible test failure when running ./mach mochitest-plain layout/mathml/tests on my build:

ERROR TEST-UNEXPECTED-FAIL | /tests/layout/mathml/tests/test_bug553917.html | Assertion count 208 is greater than expected range 204-204 assertions.
(Assignee)

Comment 1

4 years ago
The assertions are all of the form:

###!!! ASSERTION: FormatStringFromName() without format parameters: use GetStringFromName() instead: 'aParams && aLength', file /home/catalin/hacking/moz/mozilla-central/intl/strres/src/nsStringBundle.cpp, line 186
(Assignee)

Comment 2

4 years ago
Created attachment 740073 [details] [diff] [review]
Patch that removes all assertions

This patch gets rid of all the assertions by using nsIStringBundle.GetStringFromName instead of nsIStringBundle.formatStringFromName when the format parameters are an empty list.

I don't really know the assertion gets triggered on my machine 208 times instead of 204 on the test machines, but it seems better to get rid of the assertion anyway and use the appropriate method of nsIStringBundle.
Attachment #740073 - Flags: review?(karlt)
Attachment #740073 - Flags: review?(karlt) → review+
(Assignee)

Comment 3

4 years ago
Adding checkin-needed following karlt's review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b27352441e
Assignee: nobody → iacobcatalin
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b6b27352441e
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.