864128 - Dropmarker too tall on editable menulists.

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: Screenshot of issue

The dropmarker of editable menulists is to tall on hover. This type of menulists isn't used in FX but in TB and SM. Bug 856040 introduced some paddings which should only apply on non-editable menulists.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: proposed fix

If you want test this on TB you can open a new Write window in HTML mode and then choose the menu Format/Page Colors and Background... Now press Advanced Edit... here you have the Attribute menulist to try.

Comment 2

[Frank Yan (:fryn)]

Comment on attachment 740078 [details] [diff] [review]
proposed fix

Review of attachment 740078 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with below comment addressed.

Thanks!

::: toolkit/themes/windows/global/menulist-aero.css
@@ +20,5 @@
>      margin-bottom: -1px !important;
>      -moz-margin-start: 0 !important;
>    }
>  
> +  menulist:not([editable="true"]) .menulist-dropmarker {

This should be:
menulist:not([editable="true"]) > .menulist-dropmarker {

Comment 3

[Frank Yan (:fryn)]

I'll push the patch for you tomorrow.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: patch for check-in

Addressed the review comment. Carrying over r+ and ui-r+

Frank, thanks for the fast review.

Comment 5

[Frank Yan (:fryn)]

Pushed today to avoid push races tomorrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/63c7f578eef7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63c7f578eef7