864160 - "Learn More" should be on the same visual line as the actions in doorhangers

Status: RESOLVED WONTFIX

(Toolkit :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of bug

See attached screenshot to see better what is happening here. The "Learn More" should not be on its own line as it looks awkward there.

On the left should be the "Learn More" and on the right should be the actions. Having the two on the same line will provide better visual balance and reduce some unnecessary whitespace.

Comment 1

[Justin Dolske [:Dolske]]

Seems like lco should comment on this first.

Comment 2

[Tanvi Vyas[:tanvi]]

In the original design, Learn More was on top since the bottom line had 2 options.
"Disable Protection on This Page" was left justified and "Keep Blocking" was right justified on the same line.

We could move Learn More down further to be in line with the drop down options.  Or we could leave it as is if we are planning to switch to the original design where "Disable Protection" is on the left and not buried in the drop down.

There have been arguments that it takes too many clicks to disable protection on Firefox (3 clicks).  Changing it to the original design would change this to 2 clicks.  In some ways that is a good thing (users less likely to disable protection) and in other ways it is annoying to users who have to go through so many clicks.

I leave this up to lco to decide.

Comment 3

[Larissa Co [:lco]]

We could also place "learn more..." (note the ellipsis, which is consistent with other links in Firefox) in line with the text string "Most websites will still work properly even when this content is blocked". 

That way, we reduce the number of lines and defer the decision to have a dropdown vs. two side-by-side buttons.

I believe Shorlander prefers the two-button layout, and I'm inclined to agree with him. It looks like we're going with something like that for Click-to-play. But while we don't have a general solution for the component yet, we can at least reduce the height of this dialog.

Also, burying "disable protection" *was* my original intent, but after seeing how terrible some pages are when we block mixed content (i.e. NYtimes) and how great they look after enabling it, I'm a bit worried that users will accuse us of crying wolf if we emphasize the Mixed Content threat too much.

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Tanvi Vyas [:tanvi] from comment #2)

> We could move Learn More down further to be in line with the drop down
> options.

That's a little tricky, implementation wise, since the row with the button is outside the the main content area.

OTOH, other such dialogs have a "Learn More" link, so maybe we should just standardize the ability to have such a link in the PopupNotification API. (Which would thus make it easy to put there in the base popup implementation, exposed/unhidden when the caller provides a URL for it to use).


(In reply to Larissa Co [:lco] from comment #3)
> We could also place "learn more..." (note the ellipsis, which is consistent
> with other links in Firefox)

IIRC in the original bug it was noted that we're actually quite inconsistent with ellipsis usage for "learn more" links. But I think it's looks really odd to have it floating there without the "…".

Comment 5

[Ranveer Aggarwal [:ranWeird]]

Hello all! 
I'd like to be assigned to this bug.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Larissa, is the plan to move this to a two-button layout? Can you share a rough sketch of what it would look like?

Comment 7

[Justin Dolske [:Dolske]]

Note that as of bug 967349, all "Learn More" links in doorhangers share the same code/markup. It's a general doorhanger feature now, so however we fix this it now only needs to be done in one place.

301 shorlander since I don't think lco is working with this stuff any more.

Comment 8

[Stephen Horlander [:shorlander]]

I will need to evaluate all of our existing panels to figure out the right approach here. I definitely won't get to this before we ship Australis though. Leaving needinfo.

Comment 9

[Stephen Horlander [:shorlander]]

Based on the work in bug 1064257 I think this is a won't fix. The panel footer will be reserved for consistent special functionality and we can keep the "Learn More…" links next to their contextually relevant messages.

https://bug1064257.bugzilla.mozilla.org/attachment.cgi?id=8504734#page=24&zoom=auto,-21,900

Comment 10

[Tanvi Vyas[:tanvi]]

Marking this as won't fix per shorlander.