864247 - Work - "Leave page" dialog should not be able to appear multiple times

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Virgil Dicu [:virgil] [QA]]

Attachment: Leave page dialog

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130421 Firefox/23.0

This is the best story I could find to block against.

1. Visit http://stackoverflow.com/questions/16141811/handle-same-events-from-different-windows
2. Type anything in the text field
3. Close the tab using the X button.
The Leave page prompt is displayed.
4. Select Back button.

Actual result: Another prompt overlaps the leave page dialog. The title text is duplicated.

Not sure what the expected behavior should be here, but the prompt should either have a relevant title and be better aligned or there should be no action allowed for back/new tab buttons while the Leave Page dialog is displayed.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

The behavior described in this bug is due to a couple of problems:
  1) The "Stay on page" dialog should not be able to appear more than once
  2) Any time a dialog appears when another dialog is already visible, the new dialog appears with no text, and the text gets appended to the old dialog

Problem 2 will be fixed by the patches in bug 866304. This bug will track only problem 1.

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

If nsDocumentViewer::PermitUnload is called and another call to nsDocumentViewer::PermitUnload has not yet returned (meaning that the user has not yet selected an option from the 'stay on page' prompt), then simply allow the unload to happen.

Another option under consideration is to disallow any unloads while the prompt is active (i.e. force the user to respond to the existing prompt, and ignore any actions that would cause another prompt to appear).

In the long run, we should probably get UX input as to what exactly should happen when the user tries to do something to a tab that already has an onbeforeunload prompt active.

For additional context/discussion, please see bug 866304:
  [1] https://bugzilla.mozilla.org/show_bug.cgi?id=866304#c19
  [2] https://bugzilla.mozilla.org/show_bug.cgi?id=866304#c29
  [3] https://bugzilla.mozilla.org/show_bug.cgi?id=866304#c31

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

https://hg.mozilla.org/integration/fx-team/rev/8d0fa17572ad

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d0fa17572ad