864271 - Permanent orange: TEST-UNEXPECTED-FAIL | browser_dataman_basics.js | Test timed out

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

Currently the suite/common/dataman/tests/browser_dataman_basics.js test times out permanently. This is due to the test_storage_load function. It is designed for the data manager being an browser extension:
779   let rootDir = "http://mochi.test:8888/browser/extensions/dataman/tests/";
780   let testURL = rootDir + "dataman_storage.html";
781   let storagetab = gBrowser.addTab(testURL);

That's not the case for SeaMonkey and therefor the test stops here and times out.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Robert: This should do the trick so that the test file works for both SeaMonkey and the dataman extension.
For SeaMonkey getRootDirectory(gTestPath) is chrome://mochikit/content/browser/suite/common/dataman/tests/, for the extension it is chrome://mochikit/content/extensions/dataman/tests as far as I see this. This results in the code using http://mochi.test:8888/broser/suite/common/dataman/tests/ and http://mochi.test:8888/browser/extensions/dataman/tests/. This is exactly what we want.

Comment 2

[Frank Wein [:mcsmurf]]

I meant "chrome://mochikit/content/browser/extensions/dataman/tests/" in Comment 1.

Comment 3

[Robert Kaiser]

Comment on attachment 743359 [details] [diff] [review]
Patch

Review of attachment 743359 [details] [diff] [review]:
-----------------------------------------------------------------

Forgot to add a comment - thanks for researching this! I was almost about to say "forget about my add-ons, make it work for SeaMonkey" but your solution is so elegant. :)

Comment 4

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/346a2722d7e9

Comment 5

[Serge Gautherie (:sgautherie)]

Was this bug supposed to be R.Fixed? (Or...)

Comment 6

[Frank Wein [:mcsmurf]]

The test still fails, but in another way. But one bug per issue, so fixed :)