Closed Bug 864271 Opened 7 years ago Closed 7 years ago

Permanent orange: TEST-UNEXPECTED-FAIL | browser_dataman_basics.js | Test timed out

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.20

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

Attachments

(1 file)

Currently the suite/common/dataman/tests/browser_dataman_basics.js test times out permanently. This is due to the test_storage_load function. It is designed for the data manager being an browser extension:
779   let rootDir = "http://mochi.test:8888/browser/extensions/dataman/tests/";
780   let testURL = rootDir + "dataman_storage.html";
781   let storagetab = gBrowser.addTab(testURL);

That's not the case for SeaMonkey and therefor the test stops here and times out.
Attached patch PatchSplinter Review
Robert: This should do the trick so that the test file works for both SeaMonkey and the dataman extension.
For SeaMonkey getRootDirectory(gTestPath) is chrome://mochikit/content/browser/suite/common/dataman/tests/, for the extension it is chrome://mochikit/content/extensions/dataman/tests as far as I see this. This results in the code using http://mochi.test:8888/broser/suite/common/dataman/tests/ and http://mochi.test:8888/browser/extensions/dataman/tests/. This is exactly what we want.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #743359 - Flags: review?(kairo)
I meant "chrome://mochikit/content/browser/extensions/dataman/tests/" in Comment 1.
Attachment #743359 - Flags: review?(kairo) → review+
Comment on attachment 743359 [details] [diff] [review]
Patch

Review of attachment 743359 [details] [diff] [review]:
-----------------------------------------------------------------

Forgot to add a comment - thanks for researching this! I was almost about to say "forget about my add-ons, make it work for SeaMonkey" but your solution is so elegant. :)
Pushed: https://hg.mozilla.org/comm-central/rev/346a2722d7e9
Target Milestone: --- → seamonkey2.20
Was this bug supposed to be R.Fixed? (Or...)
Flags: needinfo?(bugzilla)
The test still fails, but in another way. But one bug per issue, so fixed :)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(bugzilla)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.