864280 - Robocop: Cleanup of BaseTest.java.in

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: BaseTest cleanup

This is a small cleanup in BaseTest:
 Since the removal of the "Open in New Tab" and "Open in Private Tab" options editBookmark and checkBookmark were timeing out waiting for "Open in New Tab". Changed them to wait for "Share" when waiting for the Bookmark's context menu to open.
 Made the changes suggested by Kats in https://bugzilla.mozilla.org/show_bug.cgi?id=747835#C16

 Try run: https://tbpl.mozilla.org/?tree=Try&rev=6bb79be0ab6b

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

good idea, this try server run looks good and an initial look at the the patch is good as well.  I don't like the idea of a variable named "SDK", I would prefer 'sdk'

Comment 2

[Adrian Tamas (:AdrianT)]

I actually renamed it sdk and also cleaned up an unused variable in the patch after the tryserver run.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 740238 [details] [diff] [review]
BaseTest cleanup

Review of attachment 740238 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5320348d5d7

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/e5320348d5d7

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Thanks for cleaning this up!