Closed Bug 864280 Opened 7 years ago Closed 7 years ago

Robocop: Cleanup of BaseTest.java.in

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: AdrianT, Assigned: AdrianT)

Details

Attachments

(1 file)

Attached patch BaseTest cleanupSplinter Review
This is a small cleanup in BaseTest:
 Since the removal of the "Open in New Tab" and "Open in Private Tab" options editBookmark and checkBookmark were timeing out waiting for "Open in New Tab". Changed them to wait for "Share" when waiting for the Bookmark's context menu to open.
 Made the changes suggested by Kats in https://bugzilla.mozilla.org/show_bug.cgi?id=747835#C16

 Try run: https://tbpl.mozilla.org/?tree=Try&rev=6bb79be0ab6b
Attachment #740238 - Flags: review?(gbrown)
good idea, this try server run looks good and an initial look at the the patch is good as well.  I don't like the idea of a variable named "SDK", I would prefer 'sdk'
I actually renamed it sdk and also cleaned up an unused variable in the patch after the tryserver run.
Comment on attachment 740238 [details] [diff] [review]
BaseTest cleanup

Review of attachment 740238 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #740238 - Flags: review?(gbrown) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5320348d5d7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.