Robocop: Cleanup of BaseTest.java.in

RESOLVED FIXED in Firefox 23

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: AdrianT, Assigned: AdrianT)

Tracking

Trunk
Firefox 23
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 740238 [details] [diff] [review]
BaseTest cleanup

This is a small cleanup in BaseTest:
 Since the removal of the "Open in New Tab" and "Open in Private Tab" options editBookmark and checkBookmark were timeing out waiting for "Open in New Tab". Changed them to wait for "Share" when waiting for the Bookmark's context menu to open.
 Made the changes suggested by Kats in https://bugzilla.mozilla.org/show_bug.cgi?id=747835#C16

 Try run: https://tbpl.mozilla.org/?tree=Try&rev=6bb79be0ab6b
Attachment #740238 - Flags: review?(gbrown)
good idea, this try server run looks good and an initial look at the the patch is good as well.  I don't like the idea of a variable named "SDK", I would prefer 'sdk'
(Assignee)

Comment 2

5 years ago
I actually renamed it sdk and also cleaned up an unused variable in the patch after the tryserver run.
Comment on attachment 740238 [details] [diff] [review]
BaseTest cleanup

Review of attachment 740238 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #740238 - Flags: review?(gbrown) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5320348d5d7
Assignee: nobody → adrian.tamas
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5320348d5d7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Thanks for cleaning this up!
You need to log in before you can comment on or make changes to this bug.