The default bug view has changed. See this FAQ.

Requesting needinfo from more than one person is annoying

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Needinfo
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: dkl)

Tracking

Production
x86
Mac OS X

Details

Attachments

(1 attachment, 1 obsolete attachment)

STEPS TO REPRODUCE:

1)  Load https://bugzilla.mozilla.org/show_bug.cgi?id=864228
2)  Scroll to the bottom.
3)  Check the "Need information from" box.
4)  Select "other" in the dropdown
5)  Type ":peterv, :bholley" in the textfield.
6)  Submit

ACTUAL RESULTS: "needinfo_from: :peterv, :bholley did not match anything"

EXPECTED RESULTS: Should work

ADDITIONAL INFORMATION: If I put that same string in the textfield I get by clicking "set flags" and setting "needinfo" to "?", then it works fine.  But that involves hunting down the "set flags" link.
(Assignee)

Comment 1

4 years ago
I will see about making the Other text field allow for more than one address to be entered, similar to the Cc field.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 740525 [details] [diff] [review]
Patch to allow multiple needinfo to be entered in Other field (v1)
Attachment #740525 - Flags: review?(glob)
Comment on attachment 740525 [details] [diff] [review]
Patch to allow multiple needinfo to be entered in Other field (v1)

Review of attachment 740525 [details] [diff] [review]:
-----------------------------------------------------------------

the layout of the 'other' box is broken due to the addition of the bz_userfield (which sets the width to 100%).  remove this class please.

if you enter a single name, you get:
Can't use string ("glob@mozilla.com") as an ARRAY ref while "strict refs" in use at ./extensions/Needinfo/Extension.pm line 111

::: extensions/Needinfo/Extension.pm
@@ +89,5 @@
>          foreach my $type (@{ $bug->flag_types }) {
>              next if $type->name ne 'needinfo';
> +            my %requestees;
> +
> +

nit: double blank line

@@ +126,1 @@
>                  }

nice!

@@ +126,4 @@
>                  }
>              }
> +
> +            next if !%requestees;

nit: you can remove this test, as the foreach loop will be a no-op if there aren't any requestees.
Attachment #740525 - Flags: review?(glob) → review-
Summary: Requesting needinfo from more than one person is a PITA → Requesting needinfo from more than one person is annoying
(Assignee)

Comment 4

4 years ago
Created attachment 740841 [details] [diff] [review]
Patch to allow multiple needinfo to be entered in Other field (v2)
Attachment #740525 - Attachment is obsolete: true
Attachment #740841 - Flags: review?(glob)
Comment on attachment 740841 [details] [diff] [review]
Patch to allow multiple needinfo to be entered in Other field (v2)

r=glob
Attachment #740841 - Flags: review?(glob) → review+
(Assignee)

Comment 6

4 years ago
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2             
modified extensions/Needinfo/Extension.pm
modified extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
Committed revision 8754.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.