864306 - Log form errors in webpay

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Kumar McMillan [:kumar]]

STR:
- make sure VERBOSE_LOGGING is False
- create a form error such as loading this URL https://marketplace.allizom.org/mozpay/?req=eyJhbGciOiAiSFMyNTYiLCAidHlwIjogIkpXVCJ9.eyJhdWQiOiAibWFya2V0cGxhY2UuYWxsaXpvbS5vcmciLCAiaXNzIjogIm1hcmtldHBsYWNlLmFsbGl6b20ub3JnIiwgInJlcXVlc3QiOiB7Im5hbWUiOiAiUHJpdmF0ZSBZYWNodCIsICJjaGFyZ2ViYWNrVVJMIjogImh0dHBzOi8vbWFya2V0cGxhY2UuYWxsaXpvbS5vcmcvc2VydmljZXMvd2VicGF5L2NoYXJnZWJhY2siLCAicHJvZHVjdERhdGEiOiAiYWRkb25faWQ9NDM2Mjc1JnNlbGxlcl91dWlkPWY2MTM3N2VmLWJjMWItNDExNi05OTYxLWY4ZjA2MzFmMWMwZiZjb250cmliX3V1aWQ9NDgxYTAxOTRjYmViZjBhMmY4NGMwNjlhMjcyOTkwOTgiLCAicHJpY2VQb2ludCI6IDEsICJpY29ucyI6IHsiNDgiOiAiaHR0cHM6Ly9tYXJrZXRwbGFjZS1jZG4uYWxsaXpvbS5vcmcvaW1nL3VwbG9hZHMvYWRkb25faWNvbnMvNDM2LzQzNjI3NS00OC5wbmc_bW9kaWZpZWQ9MTM2MTQ4MTYyMiIsICIzMiI6ICJodHRwczovL21hcmtldHBsYWNlLWNkbi5hbGxpem9tLm9yZy9pbWcvdXBsb2Fkcy9hZGRvbl9pY29ucy80MzYvNDM2Mjc1LTMyLnBuZz9tb2RpZmllZD0xMzYxNDgxNjIyIiwgIjY0IjogImh0dHBzOi8vbWFya2V0cGxhY2UtY2RuLmFsbGl6b20ub3JnL2ltZy91cGxvYWRzL2FkZG9uX2ljb25zLzQzNi80MzYyNzUtNjQucG5nP21vZGlmaWVkPTEzNjE0ODE2MjIiLCAiMTI4IjogImh0d


A generic "error with that request" message is displayed. This is fine but in order to debug the issue, a developer needs access to the actual form error. We should log the form error for diagnosis.

Comment 1

[Kumar McMillan [:kumar]]

There might be something that isn't calling the error handler right. In checking into bug 868956 I verified that VERBOSE_LOGGING is True on stage but we still don't get a verbose error. I added this to try and catch it https://github.com/kumar303/webpay/commit/530809876e442023ba6b884d0112c1dc3219a00a

Comment 2

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/webpay/commit/027e86e63ae2761e272385fee2c7c16e8de3759b

Added logging to anytime we hit the error view, which includes when this form throws an error.