864308 - [as] review notes for Assamese fx 21

Status: RESOLVED FIXED

(Mozilla Localizations :: as / Assamese, defect)

Description

[Axel Hecht [:Pike]]

In fonts.dtd, there are some weird accesskeys, notably, () turns '(' into an accesskey often. The () shouldn't really be part of the localized string, either. That breaks display on the mac.

Similarly in installer/custom.properties, $BrandShortName &Safe Mode becomes
$BrandShortName সুৰক্ষিত অৱস্থা (&)

I'm going to take the sign-off nevertheless, but it'd be good to fix the regressions for 22 at least.

Comment 1

[Nilamdyuti]

Hi Axel,

I have noticed these accesskeys in fonts.dtd. I don't know how it came into place because I wouldn't have placed them without any reason. In installer/custom.properties I can see that I clearly missed out the 'S' after '&'. I will make the fixes for Firefox aurora 22. Thanks for pointing out.

Comment 2

[Nilamdyuti]

Hi Axel,

I have made the fixes in Firefox aurora 22 in locomotion. But, I have noticed some weird things while fixing the issues. Most of the accesskeys in majority of the files were missing in locomotion. I had to put them again. It is to be noted that these accesskeys were there when I used to do translation in 'hg' i.e, when the files were in '.dtd' and '.properties' format.

When I opened the fonts.dtd.po file in locomotion for fixing the issues I found there were no accesskeys in the localized strings. e.g:

msgid: &Serif:
msgstr: Serif:

Whereas when I opened the original file from hg i.e, fonts.dtd for Assamese in gedit, it was like this:

<!ENTITY  serif.label                             "Serif ():">

As far as I can remember I have never missed putting a accesskey in localized string if one was there in source string.

So, how the accesskey got removed in 'locomotion' and how come empty parentheses came in 'hg'?

There seems to be some issue in format conversion ('.dtd' to '.dtd.po', '.properties' to '.properties.po' and vice versa)  during migration from hg to pootle and vice versa.

If there is an issue in format conversion, it needs to be fixed otherwise I would end up doing the same thing again and again.


Thanks,
Nilamdyuti

Comment 3

[Axel Hecht [:Pike]]

I don't know much about the infra - Dwayne?

Comment 4

[Nilamdyuti]

Completely reviewed firefox aurora 22 in locomotion and placed the access keys where they were missing. I hope they stay in place and don't turn into empty parentheses when format conversion happens during migration of changes from pootle to hg.

Thanks,
Nilamdyuti

Comment 5

[Nilamdyuti]

After my review and correction on pootle, this is what is submitted in the hg repo today:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/diff/57219dedd6bc/browser/chrome/browser/preferences/fonts.dtd

whereas the contents of the english fonts.dtd file is as follows:

<!ENTITY  proportional.label                      "Proportional:">
<!ENTITY  proportional.accesskey                  "P">

and the translations I have done on pootle (locamotion) is as follows:

#: proportional.label proportional.accesskey
msgid "&Proportional:"
msgstr "সমানুপাতিক (&P):"

So, I am not sure, how to translate these kind of entries in pootle which will bring the correct translations in hg.

Thanks,
Nilamdyuti

Comment 6

[Dwayne Bailey]

I spent some time with @Nilamdyuti on the #Pootle checking the options.

- po2moz - will in DTD files, take an accesskey marked with & in the target and extract the accesskey.  If no accesskey is specified then it will default to the English.

The only way an accesskey can become ( is if the source has e.g. "Xxxx (&)".

The solution for now, for languages such as "as" (i.e. not latin or no keyboard characters), is to simply ignore accesskeys in the source when translations and to set intl.properties::intl.menuitems.alwaysappendaccesskeys = true

I'll leave this open so that the general fixes for accesskeys can land.

Comment 7

[Nilamdyuti]

Hi Dwayne,

Thanks for clearing the doubt.

Comment 8

[Dwayne Bailey]

Changeset 9eed08c04120 fixes the accesskeys to use to let Firefox append the accesskey as needed.

Comment 9

[Nilamdyuti]

Fixed the access keys issues on pootle on 7th May, the changeset 9eed08c04120 was pushed to hg on 8th May. Checked the diff on hg and found that the accesskeys look alright there. Hence, signed off the changeset. Thanks Axel for raising this issue and thanks to Dwayne for clearing the doubt.