Closed Bug 864395 Opened 7 years ago Closed 5 years ago

The "I want to help B2G OS by sharing data..." is not doing anything

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox32 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
Tracking Status
firefox32 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: fabrice, Assigned: jchen)

References

Details

Attachments

(2 files, 2 obsolete files)

Checking this checkbox switches the "debug.performance_data.shared" settings, but we don't do anything with this one in gecko.

So we should either remove this page, or do whatever is expected on the gecko side, but that would be new feature work.
I think its intention was to turn on Telemetry, but not sure if any probes are implemented for B2G.
I'm working on getting the setting to turn Telemetry on and off.
Assignee: nobody → nchen
Status: NEW → ASSIGNED
FWIW this patch associates the setting with the actual telemetry pref, but from what I can tell, some more work is needed to actually get telemetry to send data.
This only affects the setting. I'll file more bugs to get telemetry to actually send data.
Attachment #8406421 - Attachment is obsolete: true
Attachment #8412039 - Flags: review?(fabrice)
Comment on attachment 8412039 [details] [diff] [review]
Associate the send perf data setting with telemetry (v1)

If MOZ_TELEMETRY_ON_BY_DEFAULT is defined, we should update the "debug.performance_data.shared" setting to true. I'm working on a patch that does that, which will replace this patch.
Attachment #8412039 - Flags: review?(fabrice)
This patch has two functions -- on first run, when the Gaia data share setting is not set, it sets the Gaia setting to match the Gecko telemetry pref. Then, when the Gaia setting is later updated by the user, it updates the Gecko pref to match the Gaia setting.
Attachment #8412039 - Attachment is obsolete: true
Attachment #8413896 - Flags: review?(fabrice)
Attachment #8413896 - Flags: review?(fabrice) → review+
The Settings app test failed because inside the test, we were tapping the "share performance data" checkbox once to see if it's checked after the tap. However, if the box is already checked (due to the setting already being set), we inadvertently uncheck the box and the test fails. Therefore, we should first uncheck the box if it's already checked.

Try: https://tbpl.mozilla.org/?tree=Try&rev=cea9cb0d3c5e
Attachment #8415539 - Flags: review?(gduan)
Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

Hi Jim,
thanks for your fix. I think it's not necessary to tap the checkbox twice if it's already enabled. Please see my comments on github.
Attachment #8415539 - Flags: review?(gduan)
Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

(In reply to George Duan [:gduan] [:喬智] from comment #10)
> Comment on attachment 8415539 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842
> 
> Hi Jim,
> thanks for your fix. I think it's not necessary to tap the checkbox twice if
> it's already enabled. Please see my comments on github.

Thanks, George! I updated the PR.
Attachment #8415539 - Flags: review?(gduan)
Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

Thanks, r=gduan
Attachment #8415539 - Flags: review?(gduan) → review+
This was merged into m-c: http://hg.mozilla.org/mozilla-central/rev/dd1032b9dcd0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Depends on: 1018344
You need to log in before you can comment on or make changes to this bug.