864395 - The "I want to help B2G OS by sharing data..." is not doing anything

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[[:fabrice] Fabrice Desré]

Checking this checkbox switches the "debug.performance_data.shared" settings, but we don't do anything with this one in gecko.

So we should either remove this page, or do whatever is expected on the gecko side, but that would be new feature work.

Comment 1

[Robert Kaiser]

I think its intention was to turn on Telemetry, but not sure if any probes are implemented for B2G.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

I'm working on getting the setting to turn Telemetry on and off.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: WIP: Associate the send perf data setting with telemetry

FWIW this patch associates the setting with the actual telemetry pref, but from what I can tell, some more work is needed to actually get telemetry to send data.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Associate the send perf data setting with telemetry (v1)

This only affects the setting. I'll file more bugs to get telemetry to actually send data.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8412039 [details] [diff] [review]
Associate the send perf data setting with telemetry (v1)

If MOZ_TELEMETRY_ON_BY_DEFAULT is defined, we should update the "debug.performance_data.shared" setting to true. I'm working on a patch that does that, which will replace this patch.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Associate the send perf data setting with telemetry (v2)

This patch has two functions -- on first run, when the Gaia data share setting is not set, it sets the Gaia setting to match the Gecko telemetry pref. Then, when the Gaia setting is later updated by the user, it updates the Gecko pref to match the Gaia setting.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eba1f5d0a908

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for Gaia integration test failures.
https://hg.mozilla.org/integration/b2g-inbound/rev/c023a60a68a8

https://tbpl.mozilla.org/php/getParsedLog.php?id=38756771&tree=B2g-Inbound

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

The Settings app test failed because inside the test, we were tapping the "share performance data" checkbox once to see if it's checked after the tap. However, if the box is already checked (due to the setting already being set), we inadvertently uncheck the box and the test fails. Therefore, we should first uncheck the box if it's already checked.

Try: https://tbpl.mozilla.org/?tree=Try&rev=cea9cb0d3c5e

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

Hi Jim,
thanks for your fix. I think it's not necessary to tap the checkbox twice if it's already enabled. Please see my comments on github.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

(In reply to George Duan [:gduan] [:喬智] from comment #10)
> Comment on attachment 8415539 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842
> 
> Hi Jim,
> thanks for your fix. I think it's not necessary to tap the checkbox twice if
> it's already enabled. Please see my comments on github.

Thanks, George! I updated the PR.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8415539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18842

Thanks, r=gduan

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

Gaia: https://github.com/mozilla-b2g/gaia/commit/8c2808c2f66b345a8c96114161010319b5803309

Gecko: https://hg.mozilla.org/integration/b2g-inbound/rev/dd1032b9dcd0

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

This was merged into m-c: http://hg.mozilla.org/mozilla-central/rev/dd1032b9dcd0