Closed Bug 864399 Opened 12 years ago Closed 12 years ago

Webapps.jsm: _nextLocalId sometimes gives a duplicated locaID

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(blocking-b2g:tef+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla23
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: amac, Assigned: amac)

Details

(Whiteboard: [fixed-in-birch][qa-])

Attachments

(1 file)

Save the pref file after each localID
811 bytes, patch
fabrice
: review+
Details | Diff | Splinter Review
_nextLocalId on Webapps.jsm isn't MT safe. We've seeing that sometimes a newly installed app is getting a localID that belongs to an already installed app, and the preference used to save the maxLocalId assigned gets assigned a lower number than some installed apps. This causes the newly installed apps to not work at all. Requesting tef+ since this affects core functionality (the ability to install and run third party apps).
No longer blocks: b2g-apps-v1-next
Assignee: nobody → amac
After talking with Fabrice on IRC and making some tests, I think the problem happens when the phone is shutdown on a non-standard way (say, removing the battery) after installing some apps. Or just after the first use on a user build (which copies webapps.json from /system to /data).
Attachment #740447 - Flags: review?(fabrice)
Attachment #740447 - Flags: review?(fabrice) → review+
blocking-b2g: tef? → tef+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5a10c10a4a09
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [fixed-in-birch] → [fixed-in-birch][qa-]
No longer blocks: b2g-apps-v1-next
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: