Closed Bug 864417 Opened 7 years ago Closed 6 years ago

broken observer calls in editor.js due to bug 795158

Categories

(MailNews Core :: Composition, defect)

defect
Not set

Tracking

(thunderbird22 fixed, thunderbird23 fixed)

RESOLVED FIXED
Thunderbird 24.0
Tracking Status
thunderbird22 --- fixed
thunderbird23 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch, v1 (obsolete) — Splinter Review
Ian made me aware what two uses of the variable |pref| haven't been converted to Services.prefs, see bug 795158 comment 31. The patch should also be uplifted to aurora and beta.
Attachment #740388 - Flags: review?(mconley)
Attachment #740388 - Flags: review?(iann_bugzilla)
Attachment #740388 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 740388 [details] [diff] [review]
patch, v1

Review of attachment 740388 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #740388 - Flags: review?(mconley) → review+
Comment on attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):
Attachment #751488 - Flags: approval-comm-beta?
Attachment #751488 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/6fd3a5c7ab95
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Attachment #751488 - Flags: approval-comm-beta?
Attachment #751488 - Flags: approval-comm-beta+
Attachment #751488 - Flags: approval-comm-aurora?
Attachment #751488 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.