Last Comment Bug 864417 - broken observer calls in editor.js due to bug 795158
: broken observer calls in editor.js due to bug 795158
Product: MailNews Core
Classification: Components
Component: Composition (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 24.0
Assigned To: Sebastian Hengst [:aryx][:archaeopteryx]
Depends on:
Blocks: 795158
  Show dependency treegraph
Reported: 2013-04-22 11:29 PDT by Sebastian Hengst [:aryx][:archaeopteryx]
Modified: 2013-05-21 02:26 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch, v1 (1.10 KB, patch)
2013-04-22 11:29 PDT, Sebastian Hengst [:aryx][:archaeopteryx]
iann_bugzilla: review+
mconley: review+
Details | Diff | Splinter Review
patch, v2, r=IanN r=mconley (1.17 KB, patch)
2013-05-19 11:11 PDT, Sebastian Hengst [:aryx][:archaeopteryx]
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Sebastian Hengst [:aryx][:archaeopteryx] 2013-04-22 11:29:16 PDT
Created attachment 740388 [details] [diff] [review]
patch, v1

Ian made me aware what two uses of the variable |pref| haven't been converted to Services.prefs, see bug 795158 comment 31. The patch should also be uplifted to aurora and beta.
Comment 1 Mike Conley (:mconley) - (needinfo me!) 2013-05-18 09:22:19 PDT
Comment on attachment 740388 [details] [diff] [review]
patch, v1

Review of attachment 740388 [details] [diff] [review]:

Comment 2 Sebastian Hengst [:aryx][:archaeopteryx] 2013-05-19 11:11:01 PDT
Created attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley
Comment 3 Sebastian Hengst [:aryx][:archaeopteryx] 2013-05-19 11:15:25 PDT
Comment on attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-05-20 05:01:57 PDT
Comment 5 Mark Banner (:standard8) 2013-05-21 02:22:54 PDT
Comment 6 Mark Banner (:standard8) 2013-05-21 02:26:52 PDT

Note You need to log in before you can comment on or make changes to this bug.