broken observer calls in editor.js due to bug 795158

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Composition
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

Trunk
Thunderbird 24.0

Thunderbird Tracking Flags

(thunderbird22 fixed, thunderbird23 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 740388 [details] [diff] [review]
patch, v1

Ian made me aware what two uses of the variable |pref| haven't been converted to Services.prefs, see bug 795158 comment 31. The patch should also be uplifted to aurora and beta.
Attachment #740388 - Flags: review?(mconley)
Attachment #740388 - Flags: review?(iann_bugzilla)

Updated

4 years ago
Attachment #740388 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 740388 [details] [diff] [review]
patch, v1

Review of attachment 740388 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #740388 - Flags: review?(mconley) → review+
Created attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley
Attachment #740388 - Attachment is obsolete: true
Comment on attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):
Attachment #751488 - Flags: approval-comm-beta?
Attachment #751488 - Flags: approval-comm-aurora?
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/6fd3a5c7ab95
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Attachment #751488 - Flags: approval-comm-beta?
Attachment #751488 - Flags: approval-comm-beta+
Attachment #751488 - Flags: approval-comm-aurora?
Attachment #751488 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/524e6222349b
status-thunderbird23: --- → fixed
https://hg.mozilla.org/releases/comm-beta/rev/2db318511ed4
status-thunderbird22: --- → fixed
You need to log in before you can comment on or make changes to this bug.