Closed
Bug 864417
Opened 12 years ago
Closed 12 years ago
broken observer calls in editor.js due to bug 795158
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(thunderbird22 fixed, thunderbird23 fixed)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: aryx, Assigned: aryx)
References
Details
Attachments
(1 file, 1 obsolete file)
1.17 KB,
patch
|
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Ian made me aware what two uses of the variable |pref| haven't been converted to Services.prefs, see bug 795158 comment 31. The patch should also be uplifted to aurora and beta.
Attachment #740388 -
Flags: review?(mconley)
Attachment #740388 -
Flags: review?(iann_bugzilla)
Attachment #740388 -
Flags: review?(iann_bugzilla) → review+
Comment 1•12 years ago
|
||
Comment on attachment 740388 [details] [diff] [review]
patch, v1
Review of attachment 740388 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #740388 -
Flags: review?(mconley) → review+
![]() |
Assignee | |
Comment 2•12 years ago
|
||
Attachment #740388 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 751488 [details] [diff] [review]
patch, v2, r=IanN r=mconley
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Attachment #751488 -
Flags: approval-comm-beta?
Attachment #751488 -
Flags: approval-comm-aurora?
![]() |
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Updated•12 years ago
|
Attachment #751488 -
Flags: approval-comm-beta?
Attachment #751488 -
Flags: approval-comm-beta+
Attachment #751488 -
Flags: approval-comm-aurora?
Attachment #751488 -
Flags: approval-comm-aurora+
Comment 5•12 years ago
|
||
status-thunderbird23:
--- → fixed
Comment 6•12 years ago
|
||
status-thunderbird22:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•