864433 - Use Strategy Pattern for client MakeAPI library

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Chris DeCairos (:cade)]

:humph pointed out that the Strategy Pattern will suit the needs of this client library well, since we need it to run in the browser and in node.

I will rewrite it to do that.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/39

Separated browser vs node XHR into different strategies, which are chosen at runtime.

Comment 2

[David Humphrey (:humph)]

Comment on attachment 742048 [details] [review]
https://github.com/mozilla/MakeAPI/pull/39

A couple of issues to fix in the code, r+ with those.  I haven't tested this in both environments, you might want to get Matt do do an additional review if you think it's necessary.

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 742048 [details] [review]
https://github.com/mozilla/MakeAPI/pull/39

Fixed up Humph's comments.

:thecount, :mjschranz - Can one (or both) of you test this in Node and in the Browser?

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 742048 [details] [review]
https://github.com/mozilla/MakeAPI/pull/39

Working server side.

Client side I can only search, but that's expected as an auth issue. Just not obvious when using search.html that this is what is wrong.

Comment 5

[Chris DeCairos (:cade)]

(In reply to Scott [:thecount] Downe from comment #4)
> Client side I can only search, but that's expected as an auth issue. Just
> not obvious when using search.html that this is what is wrong.

The search.html page is set up to use the default password in .env.sample

If it's been changed in your .env then you can expect it not to authenticate.

This sounds good to land.

Comment 6

[Chris DeCairos (:cade)]

Staged on Master: https://github.com/mozilla/MakeAPI/commit/3f63628f6a57f26c56748e6938845b148132eb42