86445 - PDT+ pipnss.jar and pipki.jar are localized - causing crashes when more languages installed

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Alexandru Savulov]

pipnss.jar and pipki.jar are localized - causing crashes when more languages
installed

Situation:

Installation Language: DE(DE)
Downloaded Language:   EN(US)
                       ("View"/"Set Language/Region>"/"Download More"
Used Language:         EN(US) 
                       ("View"/"Set Language/Region>"/"English(US)"
pip*.jar Language:     DE(DE)

Now goto "Edit"/"Preferences", then expand "Privacy and Security" and click on
the empty space where "Validation" should appear. => CRASH

Comment 1

[Alexandru Savulov]

added "crash" to keywords

Comment 2

[rchen]

Language pack issues.

Reassigned to tao.

Comment 3

[msanz]

Frank, can Juraj look into this one? reassigning to him

Comment 4

[[e-mail] (away - not reading bugmail)]

accepting for 0.9.3

Comment 5

[Frank Tang]

put into nsbranch. need to assess the risk when we have patch. Not necessary low
risk bug. 

Comment 6

[Frank Tang]

PDT+ per pdt meeting.
we need to analysis the risk once we got a patch

Comment 7

[[e-mail] (away - not reading bugmail)]

Alexandru,

could please explain the step below leading to the crash? The pane "Privacy and 
Security" has been only recently populated - with two text labels. Is 
validation a button? Where should it appear, could you please provide the name 
of the pref pane? I'm assuming you were using 6.1 Preview Release for this. 
Correct?

Alexandru, thanks for all your help and please help us understand better, how 
to reproduce your crash. This has been marked with high priority and I'd like 
to produce a patch within a the next few days...

cc'ing nhotta, tao and ftang



Now goto "Edit"/"Preferences", then expand "Privacy and Security" and click on
the empty space where "Validation" should appear. => CRASH

Comment 8

[Alexandru Savulov]

"Validation" ist the last subitem of the "Privacy and Security" item of the 
tree. 
(btw on german the item becomes "Auswertung" - what is actually wrong be cause
"Validation" translates to "Validierung", "Gueltigkeitspruefung", "Bewertung". 
"Auswertung" translates to "Evaluation")

Ok, let me see if i can provide you the files pip*.jar (DE) from my machine.
Then note the steps I took to get them. Please make sure that you start with 
installing the german version. (Start with the german page netscape.de).

If this is not enough, let me know an I will provide you the zipped directory 
content from that machine. Maybe you want to know that i didn't change anything 
on the machine I use and that I still have the bug here (unfortunatelly in San 
Diego).  

Comment 9

[Alexandru Savulov]

Attachment: the german versions of pip*.jar files received during installation

Comment 10

[Alexandru Savulov]

Also submiting forms leads to a crash if choosing to use a different language 
than the one of the pip*.jar files

Comment 11

[[e-mail] (away - not reading bugmail)]

Alexandru,

thanks for submitting the additional info! Please correct me, if I'm wrong, but 
I have the impression that this pref panel exists only in commercial builds. 
That would explain my initial confusion about the feature, since I was looking 
at Mozilla builds. 

If this is true, we should either mark this Netscape confidential or move the 
bug into Bugscape.

Although you are probably quite right when questioning the correctness of the 
German translation, I'd not go as far as invalidating the wording our 
localization vendor has chosen. I looked up some contemporary German idioms 
around certificates and I'd personally lean towards "Gültigkeitsprüfung" or 
maybe even better "Validierung". See an example of the documents I looked at 
here:

http://www.mi.uni-koeln.de/~lehn/Krypto/IPSec16.PDF

The German language is - especially when it comes to technology - full of new 
word creations, many of them are taken directly from English. However, I'd 
leave the wording to the localization vendor, as they are also evaluating the 
stylistic and linguistic context. I suspect that they are not domain experts 
and most likely didn't understand the functionality of this feature well enough 
to come up with a more sensible translation. 

I'd suggest a follow up with mcarlson, our l10n manager, and perhaps filing a 
tracking bug to keep people focused?

Now, onto the crasher...

Comment 12

[[e-mail] (away - not reading bugmail)]

tentatively marking dependency on bug 86807.

I followed the repro steps with the German PR1 build and all I've noticed was, 
that the two pref panels "Zertifikate" and "Auswertung" (Certificates, 
Validation) appeared in German although the UI language has been switched to US 
English.

However, when mingling old and new profiles and changing the UI language 
settings, the overlay problem from bug 86807 kicks in - as manifested by 
missing menu items. Upon entering the pref window I'm missing pref tree entries 
for "Master Passwords", "SSL", "Certificates" and "Validation". When clicking 
any of those pref panes, Netscape crashes...

I'll run a full commercial build and attempt to reproduce it there. Alexandru, 
could you please send me the contents of your profile directory or at least the 
pertinent profile you used for testing? Is it a new or an old profile?

Comment 13

[[e-mail] (away - not reading bugmail)]

Attachment: zipped crash profile files

Comment 14

[[e-mail] (away - not reading bugmail)]

confirming dependecy on bug 86807.

Updated repro steps:

1) install a German commercial build - if you have a US build, please place the 
German pipnss.jar and pipki.jar Alexandru has provided into your chrome 
directory.

2) create a new profile

3) replace some files in the newly created profile directory with the contents 
of the attached crasher profile

4) restart the browser using this altered new profile, open the pref window and 
click on the last pref pane under the node "Privacy and Security"

5) Netscape crashes with the stack trace below.

Stack Trace  
CERT_LockDB() 
SEC_TraversePermCerts() 
nsNSSCertificateDB::GetOCSPResponders 
[d:\builds\seamonkey\mozilla\security\manager\ssl\src\nsNSSCertificate.cpp, 
line 2920] 
XPTC_InvokeByIndex 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, 
line 139] 
XPCWrappedNative::CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 
1837] 
XPC_WN_CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, 
line 1242] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 809] 
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2703] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 825] 
js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 897] 
JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3322] 
nsJSContext::CallEventHandler 
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 937] 
nsJSEventListener::HandleEvent 
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 140] 
nsEventListenerManager::HandleEventSubType 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, 
line 1120] 
nsEventListenerManager::HandleEvent 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, 
line 1793] 
GlobalWindowImpl::HandleDOMEvent 
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 600] 
DocumentViewerImpl::LoadComplete 
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp, line 1117] 
nsDocShell::EndPageLoad 
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3630] 
nsWebShell::EndPageLoad 
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp, line 902] 
nsDocShell::OnStateChange 
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3551] 
nsDocLoaderImpl::FireOnStateChange 
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 1096] 
nsDocLoaderImpl::doStopDocumentLoad 
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 735] 
nsDocLoaderImpl::DocLoaderIsEmpty 
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 633] 
nsDocLoaderImpl::OnStopRequest 
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 564] 
nsLoadGroup::RemoveRequest 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsLoadGroup.cpp, line 517] 
imgRequestProxy::OnStopRequest 
[d:\builds\seamonkey\mozilla\modules\libpr0n\src\imgRequestProxy.cpp, line 381] 
imgRequest::OnStopRequest 
[d:\builds\seamonkey\mozilla\modules\libpr0n\src\imgRequest.cpp, line 639] 
ProxyListener::OnStopRequest 
[d:\builds\seamonkey\mozilla\modules\libpr0n\src\imgLoader.cpp, line 373] 
nsJARChannel::OnStopRequest 
[d:\builds\seamonkey\mozilla\netwerk\protocol\jar\src\nsJARChannel.cpp, line 
587] 
nsOnStopRequestEvent::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp, line 
159] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 524] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 1072] 

Comment 15

[[e-mail] (away - not reading bugmail)]

per discussion with tao it looks like this might be related to user-locales.rdf 
and some problems in chrome registry. I'm verifying with Alex, the reporter of 
this bug, to see if this theory really applies. If so, we have to come up with 
some contingency plan since Hyatt is not here and the crasher occurs in the 
PSM, which makes it a little tougher to patch it up.

Comment 16

[[e-mail] (away - not reading bugmail)]

this crash only occurs in Alex's build. A fresh install of 6.1 PR1 En Win32 
build doesn't yield the crash as described. However, placing a modified all-
locales.rdf in the browser chrome directory will lead to a crash, when a new 
profile is created and the UI language is switched to German.

I'm attaching both the modified and the working version of all-locales.rdf. I'm 
investigating, what steps lead to the same state of the all-locales.rdf as seen 
in Alex's PR1 install. This will determine the significance of the bug.

Comment 17

[[e-mail] (away - not reading bugmail)]

Attachment: all-locales.rdf required to reproduce the crash

Comment 18

[[e-mail] (away - not reading bugmail)]

- this crash only occurs if all-locales.rdf points to an non-existent locale. 
  There two known ways to achieve this so far, both of them are fairly 
  untypical and not expected to be encountered during normal use of the 
  product. 

- the PSM team needs to move (repackage) both pipnss.jar and pipki.jar for RTM.
  Locale-specific files, which needs to go into en-US.jar, de-DE.jar, ja-JP.jar 
  or fr-FR.jar respectively. I'm attaching a sample packaging for en-US and de-
  DE.

Repro steps:

 - install build X in locale X and install another build Y in locale Y. Use 
   build X with language X, later download language pack and switch to language 
   Y. Note that the PSM-related pref panels still show in language X. This 
   appears due to the fact that pipnss.jar and pipki.jar both contain locale-
   specific files, which needs to go into en-US.jar, de-DE.jar, ja-JP.jar or fr-
   FR.jar respectively. Now copy pipnss.jar and pipki.jar from build Y's chrome
   directory to build X's chrome. Start build X and click on the the last PSM 
   pref panel to crash Netscape. 

-  this again requires two build - X and Y. Create a new profile with build X,
   then start build Y and switch to language X after downloading the 
   corresponding language pack. Restart Y and click on the the last PSM 
   pref panel to crash Netscape. 

Comment 19

[[e-mail] (away - not reading bugmail)]

cc'ing ddrinan from the PSM team for the crasher

Comment 20

[[e-mail] (away - not reading bugmail)]

Attachment: French pippki.jar and pipnss.jar - please copy these into the chrome directory of an US Netscape build to repro the crash

Comment 21

[[e-mail] (away - not reading bugmail)]

Attachment: Example of repackaged German and US English PSM jar and language pack files. Copy these into an US or German build, they should allow you to switch the UI language between US English and German w/o crashing or mingling languages.

Comment 22

[[e-mail] (away - not reading bugmail)]

pre ftang's suggestion - sending over to ddrinan to address the PSM crasher. 
Will assist with repro of the crash as needed. Repackaging for RTM will be 
pursued separately.

Comment 23

[[e-mail] (away - not reading bugmail)]

cc'ing rchen, granrose, amasri and ssu for the packaging issue

Comment 24

[[e-mail] (away - not reading bugmail)]

marking dependency on bug 76915, which has been marked "topcrash" and has the 
same stack Talkback signature: CERT_LockDB().

Comment 25

[David P. Drinan]

I'm pretty sure that this is a dup of
http://bugzilla.mozilla.org/show_bug.cgi?id=77837.

We had to back out the fix for 77837 because it was causing blockers in the
installer builds (but not in our developer builds). If someone could take a look
at the proposed patch for 77837 and help me figure out what's either wrong with
it or what's missing, that would be a great help.

Comment 26

[[e-mail] (away - not reading bugmail)]

David,

I glanced over bug 77837 and couldn't make much out of it. I'll try to go over 
it again. The repackaging seems to be quite straightforward and I believe rchen 
said the right thing in bug 77837. Please have a look at the attachment 41305 [details], 
it contains repackaged US and DE jars and seems to work well with PR1 release 
builds...

Comment 27

[David P. Drinan]

I've updated the patch for 77837 that I think fixes the installer issues.

Comment 28

[Andreas Becker]

mass change, switching qa contact from jonrubin to ruixu.

Comment 29

[Stephane Saux]

marking fixed by fix to 77837 as per ddrinan comments.

Comment 30

[Rui Xu]

Verify fixed with DE6.1 RTM build on DE Win98SE.