Closed Bug 864521 Opened 7 years ago Closed 7 years ago

Replace Fennec's AndroidKeyEvent::KEYCODE enum with Android's AKEYCODE enum

Categories

(Firefox for Android :: Keyboards and IME, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 23
Tracking Status
firefox22 --- wontfix
firefox23 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

As suggested in bug 842927 comment 143 and 144, replace Fennec's AndroidKeyEvent::KEYCODE enum with Android's AKEYCODE enum from #include <android/keycodes.h>. This will make Android/Gonk code sharing a little easier.

Unfortunately, Android's AKEYCODE enum is missing some recent keycodes, so we need to polyfill them for Fennec (in AndroidJavaWrappers.h).
Attachment #740495 - Flags: review?(nchen)
Comment on attachment 740495 [details] [diff] [review]
replace-AndroidKeyEvent-with-AKEYCODE.patch

Looks good. Thanks!
Attachment #740495 - Flags: review?(nchen) → review+
https://hg.mozilla.org/mozilla-central/rev/7eba4d94e5a7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.