Closed
Bug 864579
Opened 12 years ago
Closed 12 years ago
Drop unnecessary const-removing casts from CalcQuirkContainingBlockHeight
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
2.39 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
CalcQuirkContainingBlockHeight has some C-style casts to strip away const-ness from nsHTMLReflowState objects. These casts may have been needed at some point in the past, but they're no longer needed.
Filing this bug on dropping them.
|
Assignee | |
Updated•12 years ago
|
Summary: Remove unnecessary const-removing casts from CalcQuirkContainingBlockHeight → Drop unnecessary const-removing casts from CalcQuirkContainingBlockHeight
|
|
Assignee | |
Comment 1•12 years ago
|
||
This probably bitrots Bug 861593 and Bug 861746's patches. If you'd prefer, I'm happy to wait for those to land, and land this after.
(I'd slightly lean towards landing this first, since otherwise we'll have an intermediate state where we'll be casting away the const guarantee of the (to-be-added) ParentReflowState() accessor, and that'd be kinda ugly / sneaky, though I guess no uglier/sneakier than the existing code.)
Attachment #740571 -
Flags: review?(cam)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 740571 [details] [diff] [review]
fix
Looks good. Land this first and I'll deal with the small amount of rot in those other bugs.
Attachment #740571 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•