Closed Bug 864579 Opened 9 years ago Closed 9 years ago

Drop unnecessary const-removing casts from CalcQuirkContainingBlockHeight

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

CalcQuirkContainingBlockHeight has some C-style casts to strip away const-ness from nsHTMLReflowState objects. These casts may have been needed at some point in the past, but they're no longer needed.

Filing this bug on dropping them.
Summary: Remove unnecessary const-removing casts from CalcQuirkContainingBlockHeight → Drop unnecessary const-removing casts from CalcQuirkContainingBlockHeight
Attached patch fixSplinter Review
This probably bitrots Bug 861593 and Bug 861746's patches. If you'd prefer, I'm happy to wait for those to land, and land this after.

(I'd slightly lean towards landing this first, since otherwise we'll have an intermediate state where we'll be casting away the const guarantee of the (to-be-added) ParentReflowState() accessor, and that'd be kinda ugly / sneaky, though I guess no uglier/sneakier than the existing code.)
Attachment #740571 - Flags: review?(cam)
Comment on attachment 740571 [details] [diff] [review]
fix

Looks good.  Land this first and I'll deal with the small amount of rot in those other bugs.
Attachment #740571 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/907b6049d995
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.