864608 - Tab drag dropmarker size and/or position needs updating for Australis

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screenshot on OS X

When you drag a tab from one window to another, the placeholder showing where the tab will be inserted doesn't have the correct position and/or size.

Comment 1

[u428464]

Ideally we would like bug 674925 fixed, but for now a new indicator is indeed needed.

Comment 2

[Matthew N. [:MattN]]

Attachment: Screenshot with patch: margin-top: -2px

Stephen, how is this? The screenshot shows the indicator between two background tabs and beside a foreground tab.

diff --git a/browser/themes/osx/browser.css b/browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -2240,11 +2240,11 @@ toolbarbutton.chevron > .toolbarbutton-m
  * Tab Drag and Drop
  */
 
 .tab-drop-indicator {
   list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
-  margin-bottom: -8px;
+  margin-top: -2px;
 }
 
 @media (min-resolution: 2dppx) {
   .tab-drop-indicator {
     list-style-image: url(chrome://browser/skin/tabbrowser/[e-mail]);

Comment 3

[Frank Yan (:fryn)]

Comment on attachment 749496 [details]
Screenshot with patch: margin-top: -2px

Stephen says that this is fine, but he prefers the dropmarker over the selected tab, not under the tab.

We select the dragged tab post-drag, so that makes sense to me too.

Comment 4

[Frank Yan (:fryn)]

In the long term, we'd want to do something more like Safari — creating a space for the dragged tab, etc. — but that's really not necesssary for Australis.

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Adjust position and z-index of the dropmarker

The z-index was adjusted so that the dropmarker appears above the selected tab (z-index: 2). On Windows and Linux we use an arrow on the bottom and I just made that slightly overlap the bottom border of the tabstrip.

Comment 6

[Frank Yan (:fryn)]

Comment on attachment 750602 [details] [diff] [review]
v.1 Adjust position and z-index of the dropmarker

Review of attachment 750602 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Matthew N. [:MattN]]

https://hg.mozilla.org/projects/ux/rev/3f2b96067735

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/3f2b96067735