864614 - Work - Tabs appending under "Tabs from Other Devices" after Sync is completed multiple times

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Sync, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: Example of tabs being appended

When syncing two different machines using the Sync feature, the same tabs will be appended under "Tabs from other devices" every time a "Sync" is completed.

Example:

- Two tabs are opened on Computer A (User Sync's)
- Sync with Computer B and the tabs appear under "Tabs from other devices" (the initial two from Computer A)
- Select Sync again on Computer B and you will notice that four tabs will appear under "Tabs from other devices" (the two initial and then the two duplicates)

Steps to reproduce the issue: (You will need two Windows 8 machines):

1) On Computer A, open Firefox Browser and select "Options" and then "Sync"
2) While still on Computer A, select "Set Up Firefox Sync" and then "Create a New Account" (Insert all the required information and create the account)
3) On the same machine (Computer A), open Firefox Metro and select "Sync" under the "Settings" charm and then select "Pair a device"
4) On Computer B, open Firefox Metro and then select "Sync" under the "Settings" charm and then select "Connect"
5) Insert the codes listed on Computer B into Computer A (Pair both of the machines)
6) Open two different tabs on Computer A and then select "Sync now" under "Settings" and then "Sync" (ensure that syncing is completed)
7) On Computer B, go into the "Settings" charm and then select "Sync" and then select "Sync now" (do this a few times)

- You will notice the two initial tabs will sync, but if you sync several more times, the same tabs will just keep getting appended under "Tabs from other Devices"
- I added a screenshot to illustrate the issue happening (reproduced it several times with different Firefox Syncing accounts)

Current Behavior:

- Same tabs keep getting appended until the "Tabs from other devices" gets completely full with the same tabs

Expected Behavior:

Shouldn't append the same tabs, if you have two tabs opened, it should only display two tabs even if you synced several times

*Note: This can happen automatically if you leave both of the browsers opened and they sync after a certain period of time*

Comment 1

[Allison Naaktgeboren :ally]

Kamil, it sounds like you are syncing between metrofx A, classic fx A("Firefox Browser" in step 1), and metrofx B. Is this correct? Can you reproduce this using only 2 firefoxen?

Comment 2

[Allison Naaktgeboren :ally]

...I bet I didn't clear the grid before repopulating when I wrote the feature.

Comment 3

[Allison Naaktgeboren :ally]

Attachment: clearing the grid

PopulateGrid() never clears the the results of last round's sync.

Picking on mbrubeck, since he reviewed the original patch (but feel free to reassign if you want to).

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 742626 [details] [diff] [review]
clearing the grid

Ship it. :)

Comment 5

[Allison Naaktgeboren :ally]

p = 2 I guess? Most of the work was tracking down the issue 

https://hg.mozilla.org/integration/mozilla-inbound/rev/20d62a6629f5

Comment 6

[Marco Mucci [:MarcoM]]

Thanks Ally.  Today I had to remove points from another Defect so we have capacity this iteration.  If Bug 864614 is ready to go then please do land it.  Let me know if you plan to and I'll add it to Iteration #6.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20d62a6629f5

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for Testing/Verification and found no issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-09-03-10-47-mozilla-central/

Changed the following settings to make Firefox Metro "Sync" faster rather then waiting:

pref("services.sync.scheduler.singleDeviceInterval", 86400);
pref("services.sync.scheduler.idleInterval",         120);
pref("services.sync.scheduler.activeInterval",       120);
pref("services.sync.scheduler.immediateInterval",    90);
pref("services.sync.scheduler.idleTime",             120);

- Synced between two different Windows 8 machines for about 3 hours, Opening/Closing "Tabs" and making sure that the both machines displayed the correct # of websites without any grid issues
- Synced 14 different websites that spanned two columns and ensured that there wasn't any grid issues