864646 - get rid nsARIAMap struct

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Not sure the summary is accurate? Looks like good cleanup though :)

Comment 2

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #1)
> Not sure the summary is accurate? Looks like good cleanup though :)

feel free to fix it :) (but technically nsARIAMap struct has gone)

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 740658 [details] [diff] [review]
patch

>+struct AttrCharacteristics
>+{
>+  nsIAtom** attributeName;

can that be more const?

>diff --git a/accessible/src/base/ARIAStateMap.cpp b/accessible/src/base/ARIAStateMap.cpp
>--- a/accessible/src/base/ARIAStateMap.cpp
>+++ b/accessible/src/base/ARIAStateMap.cpp
>@@ -1,17 +1,15 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* vim: set ts=2 et sw=2 tw=80: */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>  * You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
>-#include "ARIAStateMap.h"
>-
>-#include "nsARIAMap.h"
>+#include "ARIAMap.h"

I'd prefer this explicitly included ARIAStateMap.h instead of relying on it being pulled in especially since its ARIAStateMap.cpp

Comment 4

[alexander :surkov (:asurkov)]

> I'd prefer this explicitly included ARIAStateMap.h instead of relying on it
> being pulled in especially since its ARIAStateMap.cpp

I don't think these files are supposed for separate usage, it's like NotificationController and EventQueue

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> Comment on attachment 740658 [details] [diff] [review]
> patch
> 
> >+struct AttrCharacteristics
> >+{
> >+  nsIAtom** attributeName;
> 
> can that be more const?

nsGkAtoms aren't const

Comment 6

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1d23eecfc4b8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d23eecfc4b8