Closed Bug 864694 Opened 8 years ago Closed 8 years ago

Remove the string "Assertion failure" from a few jsreftest descriptions to avoid TBPL false positives

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: emorley, Assigned: emorley)

Details

(Keywords: sheriffing-P2)

Attachments

(1 file)

TBPL currently matches on 'Assertion failure:' (https://hg.mozilla.org/webtools/tbpl/file/29cad65aeb7f/php/inc/GeneralErrorFilter.php#l30), so that MOZ_ASSERTs appear in TBPL's log failure summary.

Unfortunately a few jsreftest have the same string in their description, meaning that the TBPL parser shows these in the summary even if the test passed.

We should just tweak the string to avoid the match.
Attached patch Patch v1Splinter Review
Yes, yuck :-(
Attachment #740723 - Flags: review?(terrence)
Comment on attachment 740723 [details] [diff] [review]
Patch v1

Review of attachment 740723 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed, yuck!
Attachment #740723 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/095979278426
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.