Closed
Bug 864694
Opened 12 years ago
Closed 12 years ago
Remove the string "Assertion failure" from a few jsreftest descriptions to avoid TBPL false positives
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: emorley, Assigned: emorley)
Details
(Keywords: sheriffing-P2)
Attachments
(1 file)
|
2.93 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
TBPL currently matches on 'Assertion failure:' (https://hg.mozilla.org/webtools/tbpl/file/29cad65aeb7f/php/inc/GeneralErrorFilter.php#l30), so that MOZ_ASSERTs appear in TBPL's log failure summary.
Unfortunately a few jsreftest have the same string in their description, meaning that the TBPL parser shows these in the summary even if the test passed.
We should just tweak the string to avoid the match.
|
||
Comment 2•12 years ago
|
||
Comment on attachment 740723 [details] [diff] [review]
Patch v1
Review of attachment 740723 [details] [diff] [review]:
-----------------------------------------------------------------
Indeed, yuck!
Attachment #740723 -
Flags: review?(terrence) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
Thank you :-)
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/095979278426
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•