Closed
Bug 864699
Opened 12 years ago
Closed 7 years ago
[FTU] Needs tests
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: fcampo, Unassigned)
Details
Attachments
(4 files)
First time experience needs some tests
|
Reporter | |
Comment 1•12 years ago
|
||
Some tests (not all of them)
Attachment #740737 -
Flags: review?(francisco.jordano)
|
||
Comment 2•12 years ago
|
||
In general pretty good work, some comments on the PR, will r+ once that are addressed.
Thanks a lot Fernando for adding the unit tests to the FTU, you rock!
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 740737 [details]
Link to patch https://github.com/mozilla-b2g/gaia/pull/9353
Awesome!
The more unit test the better!
Thanks Fernando!
Attachment #740737 -
Flags: review?(francisco.jordano) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
Merged on https://github.com/mozilla-b2g/gaia/commit/ac68b0f23dd67aff4a8a5ef05d4cd89684f52018
Will leave the bug open till at least 90% of the features have tests
|
|
Reporter | |
Comment 5•12 years ago
|
||
As I'm still unable to create a proper test to deal with history.back, I prefer to delete it, cause it will fail.
Attachment #741912 -
Flags: review?(francisco.jordano)
|
|
||
Updated•12 years ago
|
Attachment #741912 -
Flags: review?(francisco.jordano) → review+
|
|
Reporter | |
Comment 6•12 years ago
|
||
Adding SIM_Management tests
Attachment #754865 -
Flags: review?(francisco.jordano)
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 754865 [details] [review]
Link to PR: https://github.com/mozilla-b2g/gaia/pull/10041
Left some comments on the pr, but are just questions or simple suggestions.
This has a nice and shinny r+ once those are addressed.
Thanks Fernando!
Attachment #754865 -
Flags: review?(francisco.jordano) → review+
|
|
Reporter | |
Comment 8•12 years ago
|
||
|
Assignee | |
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
|
Reporter | |
Comment 9•11 years ago
|
||
Attachment #819819 -
Flags: review?(jmcf)
|
||
Comment 10•11 years ago
|
||
Comment on attachment 819819 [details] [review]
Fix navigation tests PR
many comments on GH have to be addressed
Attachment #819819 -
Flags: review?(jmcf) → review-
|
|
Reporter | |
Comment 11•11 years ago
|
||
Comment on attachment 819819 [details] [review]
Fix navigation tests PR
Pull request updated addressing all the comments. Please review again
Attachment #819819 -
Flags: review- → review?(jmcf)
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 819819 [details] [review]
Fix navigation tests PR
it seems the errors reported by Travis have nothing to do with this patch
thanks!
Attachment #819819 -
Flags: review?(jmcf) → review+
|
||
Comment 13•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•