Closed Bug 864751 Opened 12 years ago Closed 12 years ago

regular profiles and DEBUG=1 profiles should live in two different directories

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rik, Assigned: kgrandon)

References

Details

(Whiteboard: [TAIPEI_FND_TRACKING], [c= , p=3])

Attachments

(2 files)

Github pull request pointer
220 bytes, text/html
julienw
: review+
Details
Pull request part 2
220 bytes, text/html
Details
We often switch between a profile that we use in Firefox Desktop with the developer tools and a profile that we send on the device. Right now, you need to |rm -rf profile| every time. I think it would be saner and more productive to use two different directories for this.
We can't actually do that this way, because there are existing scripts that would break if we'd do such a change. However, Vivien and I discussed about that lately and we thought the best solution could be to add a "PROFILE=" env variable, that would control the directory name where the profile will be stored. This way, we can easily write new scripts without breaking existing scripts.
BTW we also thought of having separate profiles for tests and developing in the browser, which is why being able to chose the profile directory name is useful too.
Do we have any script that uses DEBUG=1 ? I wouldn't expect that since it breaks the device. If there's no script using it, we can keep the current default profile/ without DEBUG=1 and write to a new directory with DEBUG=1.
Every person that runs the unit tests in a scripted way have scripts that do that. I do, for example, but I'm quite sure releng do that too for tbpl. I don't want to change that now that we're quite close to have tbpl working. Oh, and the Travis script (that should be easy to fix too, granted).
Tony, Julien, we are like minded! I totally agree we should have a configurable GAIA_PROFILE env variable.
Whiteboard: [TAIPEI_FND_TRACKING]
Ideally, I'd like to see a separate tree for all generated files, not just the profile (so similar in concept to objdir-gecko for the gecko tree). This allows the source tree to remain "clean".
Good idea Dave ! But I think this could be in another bug. Would you please file one ?
This is a good idea and I've wanted it for a while. I'm going to implement something, and I don't think it would be too hard to fix up any broken scripts and find the ones to fix after a few emails to the mailing lists.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attachment #765199 - Flags: review?(21)
Comment on attachment 765199 [details] Github pull request pointer Adding a few people for review - anyone feel free to take a look and comment. Thanks.
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer finished the review on github thanks !
Attachment #765199 - Flags: review?(felash)
Attachment #765199 - Flags: review?(21)
You'll need to change travis.sh also to use the right profile folder.
AFAIK that's already in the patch ;)
Whiteboard: [TAIPEI_FND_TRACKING] → [TAIPEI_FND_TRACKING], c= ,
Comment on attachment 765199 [details] Github pull request pointer Ok Julien - I think this is ready for another review. Thanks!
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer Er, give me one minute. Might need to fix one thing.
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer Nevermind, it was a bad alias. This should *really* be ready for another pass :)
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer last round of comments I guess ! :)
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer Awesome - last requests have been implemented. Thanks for the reviews!
Attachment #765199 - Flags: review?(felash)
Comment on attachment 765199 [details] Github pull request pointer r=me thanks !
Attachment #765199 - Flags: review?(felash) → review+
a=npotb means we should push this to v1-train too, right ?
This is not "not part of the build". It is the build system… But I'd like to see it on as many branches as possible.
Attached file Pull request part 2 —
This is part 2. I must've made a mistake during rebasing to master. This was a simple typo fix which brought the code into the R+'d expected state.
This has landed, but unfortunately there are two merge commits. A second smaller fix seemed better than backing everything out and generating the same amount of commits. Part 1: https://github.com/mozilla-b2g/gaia/commit/16178947f4f68a371226d284021f9a4461c28675 Part 2: https://github.com/mozilla-b2g/gaia/commit/1c4da9d4a0b2bae459d3d199b8ca7aa1b96725ad
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [TAIPEI_FND_TRACKING], c= , → [TAIPEI_FND_TRACKING], c= ,p=3
Whiteboard: [TAIPEI_FND_TRACKING], c= ,p=3 → [TAIPEI_FND_TRACKING], [c= , p=3]
So should we land this on v1-train without leo+ or approval, with a=build ?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: